comments and remove uneccessary method

Signed-off-by: Andres Taylor <[email protected]>

Author: systay

go/keys/schemaInfo.go

@@ -30,6 +30,10 @@ import (
 var _ semantics.SchemaInformation = (*SchemaInfo)(nil)
 
 type (
+	// SchemaInfo is a simple implementation of semantics.SchemaInformation
+	// It will claim that any table that is asked for is present in the schema, with no columns specified and authoratative columns set to false
+	// it has a createTableHandler that can be used to populate the schema if the
+	// query log contains the CREATE TABLE statements
 	SchemaInfo struct {
 		KsName string
 		Tables map[string]Columns

go/transactions/transactions.go

@@ -55,7 +55,7 @@ type (
 func Run(cfg Config) {
 	s := &state{
 		parser: sqlparser.NewTestParser(),
-		si:     getFakeSchema(),
+		si:     &keys.SchemaInfo{},
 		txs:    newTxSignatureMap(),
 	}
 	s.run(os.Stdout, cfg)
@@ -368,31 +368,3 @@ func (s *state) getAutocommitGuess(cfg Config) bool {
 	})
 	return defaultAutocommit
 }
-
-func getFakeSchema() *keys.SchemaInfo {
-	// WIP: dummy data
-	// TODO: Use real schema information data with the 'vt schema' JSON output
-	si := &keys.SchemaInfo{
-		Tables: map[string]keys.Columns{
-			"tblA": {
-				{Name: sqlparser.NewIdentifierCI("apa")},
-				{Name: sqlparser.NewIdentifierCI("foo")},
-				{Name: sqlparser.NewIdentifierCI("id")},
-			},
-			"tblB": {
-				{Name: sqlparser.NewIdentifierCI("monkey")},
-				{Name: sqlparser.NewIdentifierCI("bar")},
-				{Name: sqlparser.NewIdentifierCI("id")},
-			},
-			"user": {
-				{Name: sqlparser.NewIdentifierCI("id")},
-				{Name: sqlparser.NewIdentifierCI("name")},
-			},
-			"user_extra": {
-				{Name: sqlparser.NewIdentifierCI("user_id")},
-				{Name: sqlparser.NewIdentifierCI("age")},
-			},
-		},
-	}
-	return si
-}

go/transactions/transactions_test.go

@@ -26,13 +26,14 @@ import (
 	"vitess.io/vitess/go/vt/sqlparser"
 
 	"github.com/vitessio/vt/go/data"
+	"github.com/vitessio/vt/go/keys"
 )
 
 func TestRun(t *testing.T) {
 	sb := &strings.Builder{}
 	s := &state{
 		parser: sqlparser.NewTestParser(),
-		si:     getFakeSchema(),
+		si:     &keys.SchemaInfo{},
 		txs:    newTxSignatureMap(),
 	}
 	s.run(sb, Config{