From ee5b634f51313ba6b66d7fc0f40149526ef8f16a Mon Sep 17 00:00:00 2001
From: Anirban Mukhopadhyay <anirbanmu@users.noreply.github.com>
Date: Thu, 2 Jan 2025 08:29:46 -0800
Subject: [PATCH] vttestserver should only pass a BindAddressGprc if one is
passed in. If none is passed in, it should pass nothing causing gRPC port to
be bound to all interfaces (instead of just 127.0.0.1).
Fixes https://github.com/vitessio/vitess/issues/17396
Signed-off-by: Anirban Mukhopadhyay <anirbanmu@users.noreply.github.com>
---
go/vt/vttest/vtprocess.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/go/vt/vttest/vtprocess.go b/go/vt/vttest/vtprocess.go
index 6371811a60e..1719fafd8a7 100644
--- a/go/vt/vttest/vtprocess.go
+++ b/go/vt/vttest/vtprocess.go
@@ -205,7 +205,7 @@ func VtcomboProcess(environment Environment, args *Config, mysql MySQLManager) (
if args.VtComboBindAddress != "" {
vtcomboBindAddress = args.VtComboBindAddress
}
- grpcBindAddress := "127.0.0.1"
+ grpcBindAddress := ""
if servenv.GRPCBindAddress() != "" {
grpcBindAddress = servenv.GRPCBindAddress()
}