fix: add --watchStdin option to exit when stdin ends #19092
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehodgkiss
force-pushed
the
stevehodgkiss/fix-stdin-eof-exit
branch
from
975e966 to
3ce8058
Compare
Fixes the issue with running Vite under Elixir and doesn't cause issues when running Vite programmatically [1] [1] vitejs#4079
stevehodgkiss
force-pushed
the
stevehodgkiss/fix-stdin-eof-exit
branch
from
3ce8058 to
03f3ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19091
Adds an optional
--watchStdinflag and config. Defaults to!process.stdin.tty(true when stdin is a pipe) when running via the CLI. Defaults to false when starting programmatically.If a new flag isn't desirable, it could be removed if the
watchStdinprop is set to!process.stdin.ttywhen running from the CLI. This would still solve the linked issue, and remove the ability to override it with CLI args.