Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 8468d41

Browse files
committedNov 12, 2024··
chore: comment
1 parent 0a3fa7e commit 8468d41

File tree

2 files changed

+2
-1
lines changed
  • packages/vite/src/node/server/environments
  • playground/rolldown-dev-react/src

2 files changed

+2
-1
lines changed
 

‎packages/vite/src/node/server/environments/rolldown.ts

+1
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ function patchRuntimePlugin(
264264
name: 'vite:rolldown-patch-runtime',
265265
renderChunk(code) {
266266
// patch rolldown_runtime to workaround a few things
267+
// TODO: is there a robust way to inject code specifically to entry or runtime?
267268
if (code.includes('//#region rolldown:runtime')) {
268269
// TODO: is this magic string heavy?
269270
const output = new MagicString(code)

‎playground/rolldown-dev-react/src/app.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function App() {
1717
</button>
1818
<pre>[virtual] {virtualTest}</pre>
1919
<pre>[alias] {testAlias}</pre>
20-
{/* TODO: app.tsx source map is slightly off? */}
20+
{/* TODO: slightly broken probably due to patching rolldown:runtime during renderChunk */}
2121
<button onClick={() => throwError()}>stacktrace</button>
2222
</div>
2323
</div>

0 commit comments

Comments
 (0)
Please sign in to comment.