chore: comment

hi-ogawa · hi-ogawa · commit 0ac290f0d60c · 2024-11-18T10:50:25.000+09:00
diff --git a/packages/vite/src/node/server/environments/rolldown.ts b/packages/vite/src/node/server/environments/rolldown.ts
@@ -298,6 +298,8 @@ class RolldownEnvironment extends DevEnvironment {
     // input is no use
     const output = this.result.output[0]
     const filepath = path.join(this.outDir, output.fileName)
+    // TODO: source map not applied when adding `?t=...`?
+    // return import(`${pathToFileURL(filepath)}`)
     return import(`${pathToFileURL(filepath)}?t=${this.buildTimestamp}`)
   }
 }
diff --git a/playground/rolldown-dev-ssr/vite.config.ts b/playground/rolldown-dev-ssr/vite.config.ts
@@ -30,7 +30,7 @@ export default defineConfig({
     rolldownDev: {
       hmr: true,
       reactRefresh: true,
-      ssrModuleRunner: true,
+      ssrModuleRunner: !process.env['NO_MODULE_RUNNER'],
     },
   },
   plugins: [

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,8 @@ class RolldownEnvironment extends DevEnvironment {`
`298`	`298`	`// input is no use`
`299`	`299`	`const output = this.result.output[0]`
`300`	`300`	`const filepath = path.join(this.outDir, output.fileName)`
	`301`	+ // TODO: source map not applied when adding `?t=...`?
	`302`	+ // return import(`${pathToFileURL(filepath)}`)
`301`	`303`	return import(`${pathToFileURL(filepath)}?t=${this.buildTimestamp}`)
`302`	`304`	`}`
`303`	`305`	`}`