Skip to content

Commit 0e19319

Browse files
authored
Merge pull request #7 from vitabletec/fix_package_name
fix: issue realted to npm auto publish workflow and remove some code …
2 parents 0818ea6 + a56e5b5 commit 0e19319

File tree

5 files changed

+100
-113
lines changed

5 files changed

+100
-113
lines changed

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
"space-in-parens": ["error", "never"],
2828
"max-len": ["error", { "code": 155, "tabWidth": 2, "ignoreUrls": true }],
2929
// added linebreak-style rule
30-
"linebreak-style": ["error", "windows"]
30+
// "linebreak-style": ["error", "windows"]
3131
}
3232
}
Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
name: Build and Publish
1+
name: Build and Publish NPM package
22

33
on:
4-
push:
5-
branches:
6-
- main
7-
4+
release:
5+
types: [published]
86
jobs:
97
build-and-publish:
108
runs-on: ubuntu-latest
@@ -13,16 +11,17 @@ jobs:
1311
shell: bash
1412
steps:
1513
- name: Checkout code
16-
uses: actions/checkout@v2
14+
uses: actions/checkout@v3
1715
- name: Use Node.js 16.x
18-
uses: actions/setup-node@v2
16+
uses: actions/setup-node@v3
1917
with:
2018
node-version: 16.x
19+
registry-url: 'https://registry.npmjs.org'
2120
- name: Install dependencies
2221
run: npm i
2322
- name: Build and publish
2423
env:
2524
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
2625
run: |
2726
npm run build
28-
npm publish
27+
npm publish

coverage/lcov.info

Lines changed: 89 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
TN:
2-
SF:src\util.js
2+
SF:src/util.js
33
FN:7,checkIsEmpty
44
FN:17,invalidNumber
55
FN:29,add
@@ -11,19 +11,19 @@ FN:105,simpleinterest
1111
FN:118,printCounting
1212
FN:134,generateOTP
1313
FN:147,checkNumber
14-
FN:163,checkPveNve
15-
FN:184,isDivisibleby7
16-
FN:194,addDigit
17-
FN:209,squareOf
18-
FN:224,reverse
19-
FN:234,exponents
20-
FN:247,primeNumber
21-
FN:260,checkLeapYear
22-
FN:269,checkEmail
23-
FN:280,checkUrl
24-
FN:290,checkZipcode
25-
FN:301,phoneNumber
26-
FN:312,checkName
14+
FN:157,checkPveNve
15+
FN:178,isDivisibleby7
16+
FN:188,addDigit
17+
FN:203,squareOf
18+
FN:218,reverse
19+
FN:228,exponents
20+
FN:241,primeNumber
21+
FN:254,checkLeapYear
22+
FN:263,checkEmail
23+
FN:274,checkUrl
24+
FN:284,checkZipcode
25+
FN:295,phoneNumber
26+
FN:306,checkName
2727
FNF:24
2828
FNH:8
2929
FNDA:4,checkIsEmpty
@@ -93,59 +93,55 @@ DA:137,0
9393
DA:138,0
9494
DA:139,0
9595
DA:148,0
96-
DA:149,0
97-
DA:151,0
98-
DA:152,0
99-
DA:154,0
96+
DA:158,0
97+
DA:159,0
98+
DA:161,0
99+
DA:162,0
100100
DA:164,0
101101
DA:165,0
102102
DA:167,0
103103
DA:168,0
104104
DA:170,0
105-
DA:171,0
106-
DA:173,0
107-
DA:174,0
108-
DA:176,0
109-
DA:185,0
110-
DA:186,0
105+
DA:179,0
106+
DA:180,0
107+
DA:189,0
108+
DA:190,0
109+
DA:191,0
110+
DA:192,0
111+
DA:193,0
111112
DA:195,0
112-
DA:196,0
113-
DA:197,0
114-
DA:198,0
115-
DA:199,0
116-
DA:201,0
113+
DA:204,0
114+
DA:205,0
115+
DA:206,0
116+
DA:207,0
117+
DA:208,0
117118
DA:210,0
118-
DA:211,0
119-
DA:212,0
120-
DA:213,0
121-
DA:214,0
122-
DA:216,0
123-
DA:225,0
124-
DA:235,0
125-
DA:236,0
126-
DA:237,0
127-
DA:239,0
128-
DA:248,0
129-
DA:249,0
130-
DA:250,0
131-
DA:252,0
132-
DA:261,0
133-
DA:270,0
134-
DA:271,0
135-
DA:272,0
136-
DA:281,0
137-
DA:282,0
138-
DA:283,0
139-
DA:291,0
140-
DA:292,0
141-
DA:293,0
142-
DA:302,0
143-
DA:303,0
144-
DA:304,0
145-
DA:313,0
146-
DA:314,0
147-
DA:315,0
148-
LF:95
119+
DA:219,0
120+
DA:229,0
121+
DA:230,0
122+
DA:231,0
123+
DA:233,0
124+
DA:242,0
125+
DA:243,0
126+
DA:244,0
127+
DA:246,0
128+
DA:255,0
129+
DA:264,0
130+
DA:265,0
131+
DA:266,0
132+
DA:275,0
133+
DA:276,0
134+
DA:277,0
135+
DA:285,0
136+
DA:286,0
137+
DA:287,0
138+
DA:296,0
139+
DA:297,0
140+
DA:298,0
141+
DA:307,0
142+
DA:308,0
143+
DA:309,0
144+
LF:91
149145
LH:30
150146
BRDA:18,0,0,0
151147
BRDA:18,0,1,2
@@ -179,40 +175,38 @@ BRDA:135,14,0,0
179175
BRDA:135,14,1,0
180176
BRDA:148,15,0,0
181177
BRDA:148,15,1,0
182-
BRDA:151,16,0,0
183-
BRDA:151,16,1,0
184-
BRDA:164,17,0,0
185-
BRDA:164,17,1,0
186-
BRDA:165,18,0,0
187-
BRDA:165,18,1,0
188-
BRDA:167,19,0,0
189-
BRDA:167,19,1,0
190-
BRDA:170,20,0,0
191-
BRDA:170,20,1,0
192-
BRDA:173,21,0,0
193-
BRDA:173,21,1,0
194-
BRDA:185,22,0,0
195-
BRDA:185,22,1,0
196-
BRDA:185,23,0,0
197-
BRDA:185,23,1,0
198-
BRDA:248,24,0,0
199-
BRDA:248,24,1,0
200-
BRDA:248,25,0,0
201-
BRDA:248,25,1,0
202-
BRDA:250,26,0,0
203-
BRDA:250,26,1,0
204-
BRDA:261,27,0,0
205-
BRDA:261,27,1,0
206-
BRDA:270,28,0,0
207-
BRDA:270,28,1,0
208-
BRDA:281,29,0,0
209-
BRDA:281,29,1,0
210-
BRDA:291,30,0,0
211-
BRDA:291,30,1,0
212-
BRDA:302,31,0,0
213-
BRDA:302,31,1,0
214-
BRDA:313,32,0,0
215-
BRDA:313,32,1,0
216-
BRF:66
178+
BRDA:158,16,0,0
179+
BRDA:158,16,1,0
180+
BRDA:159,17,0,0
181+
BRDA:159,17,1,0
182+
BRDA:161,18,0,0
183+
BRDA:161,18,1,0
184+
BRDA:164,19,0,0
185+
BRDA:164,19,1,0
186+
BRDA:167,20,0,0
187+
BRDA:167,20,1,0
188+
BRDA:179,21,0,0
189+
BRDA:179,21,1,0
190+
BRDA:179,22,0,0
191+
BRDA:179,22,1,0
192+
BRDA:242,23,0,0
193+
BRDA:242,23,1,0
194+
BRDA:242,24,0,0
195+
BRDA:242,24,1,0
196+
BRDA:244,25,0,0
197+
BRDA:244,25,1,0
198+
BRDA:255,26,0,0
199+
BRDA:255,26,1,0
200+
BRDA:264,27,0,0
201+
BRDA:264,27,1,0
202+
BRDA:275,28,0,0
203+
BRDA:275,28,1,0
204+
BRDA:285,29,0,0
205+
BRDA:285,29,1,0
206+
BRDA:296,30,0,0
207+
BRDA:296,30,1,0
208+
BRDA:307,31,0,0
209+
BRDA:307,31,1,0
210+
BRF:64
217211
BRH:22
218212
end_of_record

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "general-js-toolkit",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"description": "A versatile and easy-to-use JavaScript library for building complex applications and web pages.",
55
"main": "dist/index.js",
66
"prettier": "./.prettierrc",

src/util.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,7 @@ export function generateOTP(lengthOfOtp) {
145145
* @returns {string} "true" if the value is a number, "false" if the value is a string.
146146
*/
147147
export function checkNumber(string) {
148-
if (typeof string === 'number') {
149-
return true;
150-
}
151-
if (typeof string === 'string') {
152-
return true;
153-
}
154-
return false;
148+
return typeof string === 'number' || typeof string === 'string';
155149
}
156150

157151
/**
@@ -268,7 +262,7 @@ export function checkLeapYear(year) {
268262
*/
269263
export function checkEmail(email) {
270264
if (checkIsEmpty(email)) return false;
271-
const validation = /^([a-zA-z0-9_\-.]+)@([a-zA-Z0-9]+.)([a-z]+)(.[a-z]+)$/;
265+
const validation = /^([a-zA-Z0-9_.-]+)@([a-zA-Z0-9]+\.)([a-z]+)(\.[a-z]+)$/;
272266
return !!email.match(validation);
273267
}
274268

0 commit comments

Comments
 (0)