Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Optimization #388

Closed
hypery2k opened this issue Jan 22, 2020 · 3 comments
Closed

Performance Optimization #388

hypery2k opened this issue Jan 22, 2020 · 3 comments
Assignees

Comments

@hypery2k
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Vis Timeline triggers periodically via setTimeout for a rerender. This causes performance issues (as shown by @luchsamapparat):

Untitled_ Jan 22, 2020 11_25 AM

Describe the solution you'd like

  • We could initially run the Vis Timeline outside the ngZone, but needs then to make change detection manual
  • I think we should also think about the setTimeout Method

Describe alternatives you've considered

Additional context
Demo: https://vistimelineexample.z22.web.core.windows.net/
Source: https://github.com/luchsamapparat/vis-timeline-example

Maybe related to #385 and #211

@hypery2k hypery2k self-assigned this Jan 22, 2020
@hypery2k
Copy link
Collaborator Author

@Thomaash
Copy link
Member

Timeline is best to be discussed with @yotamberk. My insight into this is limited.

@hypery2k
Copy link
Collaborator Author

Could be verified with Lighthouse CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants