From f6cf3e8705070eac561b42cf338a1b735fceedf3 Mon Sep 17 00:00:00 2001 From: Chris Tsang Date: Thu, 30 May 2024 10:04:23 +0100 Subject: [PATCH] Refactor --- cmdapp/src/converter.rs | 6 +++--- webapp/src/conversion/color_image.rs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cmdapp/src/converter.rs b/cmdapp/src/converter.rs index d0c4c2b..cfa4fa5 100644 --- a/cmdapp/src/converter.rs +++ b/cmdapp/src/converter.rs @@ -73,7 +73,7 @@ fn should_key_image(img: &ColorImage) -> bool { // Check for transparency at several scanlines let threshold = ((img.width * 2) as f32 * KEYING_THRESHOLD) as usize; - let mut num_transparent_boundary_pixels = 0; + let mut num_transparent_pixels = 0; let y_positions = [ 0, img.height / 4, @@ -84,9 +84,9 @@ fn should_key_image(img: &ColorImage) -> bool { for y in y_positions { for x in 0..img.width { if img.get_pixel(x, y).a == 0 { - num_transparent_boundary_pixels += 1; + num_transparent_pixels += 1; } - if num_transparent_boundary_pixels >= threshold { + if num_transparent_pixels >= threshold { return true; } } diff --git a/webapp/src/conversion/color_image.rs b/webapp/src/conversion/color_image.rs index 0cd15ad..edfa0c0 100644 --- a/webapp/src/conversion/color_image.rs +++ b/webapp/src/conversion/color_image.rs @@ -233,14 +233,14 @@ impl ColorImageConverter { // Check for transparency at several scanlines let threshold = ((img.width * 2) as f32 * KEYING_THRESHOLD) as usize; - let mut num_transparent_boundary_pixels = 0; + let mut num_transparent_pixels = 0; let y_positions = [0, img.height / 4, img.height / 2, 3 * img.height / 4, img.height - 1]; for y in y_positions { for x in 0..img.width { if img.get_pixel(x, y).a == 0 { - num_transparent_boundary_pixels += 1; + num_transparent_pixels += 1; } - if num_transparent_boundary_pixels >= threshold { + if num_transparent_pixels >= threshold { return true; } }