Only allow changing of document root if virtualmin is not installed

https://forum.virtualmin.com/t/nginx-changing-default-root-directory-breaks-virtualmin/134173

Author: jcameron

edit_sdocs.cgi

@@ -16,8 +16,10 @@ print &ui_form_start("save_sdocs.cgi", "post");
 print &ui_hidden("id", $in{'id'});
 print &ui_table_start($text{'docs_header'}, undef, 2);
 
-print &nginx_opt_input("root", $server, 60, undef,
-		       &file_chooser_button("root", 1));
+if (!&foreign_check("virtual-server")) {
+	print &nginx_opt_input("root", $server, 60, undef,
+			       &file_chooser_button("root", 1));
+	}
 
 print &nginx_opt_input("index", $server, 60, undef, undef, 1);
 

save_sdocs.cgi

@@ -12,11 +12,13 @@ my $server = &find_server($in{'id'});
 $server || &error($text{'server_egone'});
 &can_edit_server($server) || &error($text{'server_ecannot'});
 
-&nginx_opt_parse("root", $server, undef, '^\/.*$');
-$in{'root_def'} || &can_directory($in{'root'}) ||
-	&error(&text('location_ecannot',
-		     "<tt>".&html_escape($in{'root'})."</tt>",
-		     "<tt>".&html_escape($access{'root'})."</tt>"));
+if (!&foreign_check("virtual-server")) {
+	&nginx_opt_parse("root", $server, undef, '^\/.*$');
+	$in{'root_def'} || &can_directory($in{'root'}) ||
+		&error(&text('location_ecannot',
+			     "<tt>".&html_escape($in{'root'})."</tt>",
+			     "<tt>".&html_escape($access{'root'})."</tt>"));
+	}
 
 &nginx_opt_parse("index", $server, undef, undef, undef, 1);
 
@@ -28,17 +30,19 @@ $in{'root_def'} || &can_directory($in{'root'}) ||
 my $name = &find_value("server_name", $server);
 &webmin_log("sdocs", "server", $name);
 
-# Redirect with the the new root directory if it was changed
-my ($dom, $domroot_curr) = split(/;/, $in{'id'});
-my $domroot_new = $in{'root'} ? $in{'root'} : undef;
-my ($return_id, $return_query) = ($in{'id'}, "");
-if ($domroot_new && $domroot_new ne $domroot_curr) {
-	&foreign_require("virtual-server");
-	my $d = &virtual_server::get_domain_by('dom', $dom);
-	if ($d) {
-		&virtual_server::clear_links_cache($d);
-		$return_id = "$dom;$domroot_new";
-		$return_query = "refresh=1";
+if (!&foreign_check("virtual-server")) {
+	# Redirect with the the new root directory if it was changed
+	my ($dom, $domroot_curr) = split(/;/, $in{'id'});
+	my $domroot_new = $in{'root'} ? $in{'root'} : undef;
+	my ($return_id, $return_query) = ($in{'id'}, "");
+	if ($domroot_new && $domroot_new ne $domroot_curr) {
+		&foreign_require("virtual-server");
+		my $d = &virtual_server::get_domain_by('dom', $dom);
+		if ($d) {
+			&virtual_server::clear_links_cache($d);
+			$return_id = "$dom;$domroot_new";
+			$return_query = "refresh=1";
+			}
 		}
 	}