Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined Variables in installimage #64

Open
dhxgit opened this issue Feb 15, 2016 · 3 comments
Open

Undefined Variables in installimage #64

dhxgit opened this issue Feb 15, 2016 · 3 comments
Labels

Comments

@dhxgit
Copy link
Member

dhxgit commented Feb 15, 2016

arch.sh uses $CIDR
CIDR is defined nowhere.

But in functions.sh is this comment:

# removed INETADDR which was ip.ip.ip.ip/CIDR - only used in arch.sh
# removed CIDR- only used in arch.sh
@dhxgit
Copy link
Member Author

dhxgit commented Feb 15, 2016

Also COMPANY is defined nowhere.
It could just be a placeholder like "virtapi_installimage"

@dhxgit dhxgit changed the title CIDR - Only used in arch.sh Undefined Variables in installimage Feb 15, 2016
@bastelfreak
Copy link
Member

$COMPANY probably needs to be set in config.sh. I don't think that we need $CIDR, we already have the subnetmask in the function.

@asciiprod
Copy link

you want CIDR for later distro version, when everything is systemd-network. Maybe replace BROADCAST param, which is hardly used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants