Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Viro...Manager requires main queue setup since it overrides 'constantsToExport' #241

Open
mypark opened this issue Apr 23, 2018 · 6 comments

Comments

@mypark
Copy link

mypark commented Apr 23, 2018

I'm getting a whole lot of warnings: Viro...Manager requires main queue setup since it overrides 'constantsToExport' since I upgraded viro into my existing project:

"react": "16.3.1",
"react-native": "^0.55.3",
"react-viro": "2.6.0",

Testing both versions of react-native 0.55.1 and 0.55.3 on the hello world viro sample, they both seem to work fine. What is causing this warning on my project? Should I suppress the warnings or somehow fix the warnings instead?

@achuvm
Copy link
Collaborator

achuvm commented Apr 23, 2018

Hi @mypark,

That's an interesting warning you have there. We don't see this warning on new or updated projects on our side, however, it could be visible due to a build setting on your existing project that isn't set on new React Native projects.

The platform should still work with the warnings, so you can either suppress it for now, or live with them. I believe the fix for the warnings needs to occur on our side, so I've created an issue on our side and we'll try to address it in our next release.

Thanks for letting us know!

@achuvm
Copy link
Collaborator

achuvm commented Apr 24, 2018

This was also reported by someone in our Slack, in order to diagnose this issue further, I have a few questions:

What devices are you seeing this error on?
Did you upgrade from 2.5.0?
Do you also see this on a new project? (react-viro init NewProj)

Thanks,

@mypark
Copy link
Author

mypark commented Apr 25, 2018

I upgraded the client and added viro to an existing project.
XCode 9.3.

This warning does not appear on a react-viro init project.

@achuvm
Copy link
Collaborator

achuvm commented Apr 25, 2018

Hi @mypark,

Thanks for the update, are you still seeing it on your upgraded project?

We think we fixed the warnings for our next release, but have been unable to reproduce it.

Due to it not reproducing on a new project, it does possibly point to some npm package conflict. Maybe compare your package.json files between your existing project and the one you just react-viro init'd.

@mypark
Copy link
Author

mypark commented Apr 26, 2018

I'm trying to re-create a vanilla project and upgrade it to get you the warning but having some troubles getting a new project upgraded. I'll see if I can post a sample project later with the reproducible warnings.

@andreleon
Copy link

andreleon commented May 20, 2018

@mypark I am also having this issue, I found out it was because I am using react-navigation. Removing this package completely gets rid of these warnings.

I still haven't figured out how to use react-navigation within a react-viro project without these warnings..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants