-
Notifications
You must be signed in to change notification settings - Fork 3
Add type information to Feats #23
Copy link
Copy link
Open
Description
Currently, the Feats column is defined as – essentially – a dict of string → string. So far, this was quite OK, perhaps with the exception of Loanword, which is initially stored as a boolean, but serializes as "True" or "False" and is read back as a string.
However, @vikibrezinova is adding an Etymology feature, which is conceptually a list. It currently serializes as e.g. Etymology=['něm.', 'lat.', 'ř.'], which is ugly, and it deserializes as a single string.
There are two possible solutions:
- Force all
Featsvalues to be strings, therefore storing the etymology list as a single value. It would be simple, but working with the list would be cumbersome. - Add some type information somewhere which would be referenced both when serializing and deserializing and which would ensure correct representation. Here, we probably want something like
Etymology=něm.,lat.,ř.
I vote for option No. 2.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels