Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect generator at DC input alarm #1418

Open
3 tasks done
ReinvdZee opened this issue Jan 30, 2025 · 7 comments
Open
3 tasks done

Detect generator at DC input alarm #1418

ReinvdZee opened this issue Jan 30, 2025 · 7 comments
Assignees
Milestone

Comments

@ReinvdZee
Copy link
Collaborator

ReinvdZee commented Jan 30, 2025

For AC generators, we provide the feature to trigger an alarm when there is no AC detected on the generator input after a period of time (5 minutes):

Image

We should provide a similar feature for DC gensets. Also, hide the AC detection feature when there is a DC genset connected and vice-versa.

For a DC genset, use the current reading of the genset for the detection and trigger an alarm if the current has been below 5A during the whole detection window. The setting is disabled by default and will not be added to GUI-V1. Since this feature uses the current reading of the connected genset, this won't be added for relay-controlled gensets.

Projects involved:

  • dbus-generator
  • gui-v2 (PR)
  • venus-platform (alarm)
@ReinvdZee ReinvdZee added this to the v3.60 milestone Jan 30, 2025
@ReinvdZee ReinvdZee self-assigned this Jan 30, 2025
ReinvdZee added a commit to victronenergy/venus-platform that referenced this issue Jan 31, 2025
@ReinvdZee
Copy link
Collaborator Author

I added a new alarm setting, which is only visible for DC genset services:

Image

The setting is never visible for the relay controlled genset. The "Detect generator at AC input" setting is hidden in case a DC genset is connected.

When the setting is enabled, an alarm will be triggered if the DC current read by the genset has not been above 5A once for 300s. As soon as the current has been above 5A once, the genset is considered running properly, until it is stopped again.

Alarm text:

Image

The new setting is com.victronenergy.settings/Settings/Generator1/Alarms/NoGeneratorAtDcIn and will not be created for startstop instance 0 (/Settings/Generator0/..). The corresponding alarm path is com.victronenergy.startstop1/Alarms/NoGeneratorAtDcIn, which will only be valid when there is a DC genset connected. Gui-v2 uses the validity of this path to determine what setting to show.

ReinvdZee added a commit to victronenergy/dbus_generator that referenced this issue Jan 31, 2025
If the DC current reported by the genset remains below 5A for the
first 5 minutes after starting, an alarm is triggered.
Also, a setting is added to enable this alarm.

victronenergy/venus#1418
@mpvader
Copy link
Contributor

mpvader commented Feb 5, 2025

nice feature! only one whish:

@philipptrenz / @ReinvdZee can you come up with a better name? "Detect generator at DC" is a bit strange wording, stranger than "at AC input".

@mpvader mpvader reopened this Feb 5, 2025
@philipptrenz
Copy link
Collaborator

Thanks, Matthijs!

@ReinvdZee How about "Alarm if DC generator is not delivering power"? It's about the same length as "Alarm when generator is not in autostart mode" and when activated, the toast provides the information, that it is only evaluated in the first 5 minutes after startup. So I think it should be clear enough.

@ReinvdZee
Copy link
Collaborator Author

@philipptrenz

How about "Alarm if DC generator is not delivering power"?

Sounds good.

And the alarm text?
"DC generator is not delivering power"?

@philipptrenz
Copy link
Collaborator

philipptrenz commented Feb 6, 2025

@ReinvdZee Sounds a bit strange, maybe we better use "providing" instead of "delivering" in both cases? I think then it's fine.

@ReinvdZee
Copy link
Collaborator Author

ReinvdZee commented Feb 10, 2025

@philipptrenz Ok, "providing" is fine with me.

Setting: "Alarm if DC generator is not providing power"
Alarm: "DC generator is not providing power"

@mpvader FYI

@ReinvdZee
Copy link
Collaborator Author

Setting:

Image

Alarm:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants