Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-red & modbustcp add new temperature types #1386

Open
mpvader opened this issue Nov 9, 2024 · 5 comments
Open

Node-red & modbustcp add new temperature types #1386

mpvader opened this issue Nov 9, 2024 · 5 comments
Assignees
Milestone

Comments

@mpvader
Copy link
Contributor

mpvader commented Nov 9, 2024

I'm not 100% sure why these were added to gui-v2, perhaps/probably to have different temperature ranges per type. Anyway, to move forward lets add them to gui-v1 as well.

Note that there is this issue as well that for Ruuvis and such its now not possible to configure any of the new types, so use local temp inputs on a GX for testing this fix.

@mpvader mpvader added the bug label Nov 9, 2024
@mpvader mpvader modified the milestones: v3.60, v3.50-fixes Nov 9, 2024
@dirkjanfaber
Copy link
Collaborator

Added to dbus_modbustcp
and to node-red-contrib-victron

But not yet in a release of the packages.

@mpvader
Copy link
Contributor Author

mpvader commented Nov 12, 2024

Can be closed @jhofstee ?

@jhofstee
Copy link
Contributor

for gui-v1, yes. But the changes of Dirk-Jan are not included yet. So I left it open for now, it either needs to be renamed and milestones updated or we need to create a new issue for that, so we won't forget it.

@dirkjanfaber
Copy link
Collaborator

Both the dbus_modbustcp and node-red-contrib-victron are in their master branches. So for me this issue can safely be closed.

@jhofstee
Copy link
Contributor

jhofstee commented Nov 12, 2024

venus issues are normally closed after the fix are included in venus and ready for testing. The reason to do that is that while you might think it is fixed in your master branch / latest release, but if that release never gets shipped, users still have the issue.

@mpvader mpvader changed the title gui-v1: add new temperature types Node-red & modbustcp add new temperature types Nov 13, 2024
@mpvader mpvader modified the milestones: v3.50-fixes, v3.60 Nov 13, 2024
@mpvader mpvader added medium_prio and removed bug labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants