Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename VeQuickItem 'isValid' to 'valid' #1820

Open
blammit opened this issue Jan 7, 2025 · 0 comments
Open

Rename VeQuickItem 'isValid' to 'valid' #1820

blammit opened this issue Jan 7, 2025 · 0 comments
Labels
medium_prio technical debt
Milestone
Version 1.1.0

Comments

@blammit
Copy link
Contributor

blammit commented Jan 7, 2025 •
edited
Loading

Originally, VeQuickItem's isValid property was named as such for consistency with other properties in that type. However, this naming has led to various porting errors, and it's also inconsistent with general QML property naming conventions that avoids starting names with is.

So, rename the property to valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium_prio technical debt
Projects
None yet
Milestone
Version 1.1.0
Development

No branches or pull requests
1 participant
@blammit