Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinboxes do not respect access roles #1764

Closed
blammit opened this issue Nov 27, 2024 · 1 comment · Fixed by #1765
Closed

Spinboxes do not respect access roles #1764

blammit opened this issue Nov 27, 2024 · 1 comment · Fixed by #1765
Assignees
@blammit
Labels
high_prio High priority
Milestone
v3.50-fixes

Comments

@blammit
Copy link
Contributor

blammit commented Nov 27, 2024

Spinboxes are editable in the "User" role, where editing is prevented in gui-v1. For example:

  • Settings > ESS > Grid set point
  • Settings > DVCC > Maximum charge current (when "Limit charge current" is activated)
@blammit blammit added the high_prio High priority label Nov 27, 2024
@blammit blammit self-assigned this Nov 27, 2024
blammit added a commit that referenced this issue Nov 27, 2024
@blammit
Respect write access in spinbox and date/time selectors
c06eb67 
Fixes #1764
@blammit blammit mentioned this issue Nov 27, 2024
Merged
@blammit
Copy link
Contributor Author

blammit commented Nov 27, 2024

While looking into this issue, I also found this other bug: #1766

@blammit blammit added this to the v3.50-fixes milestone Nov 28, 2024
blammit added a commit that referenced this issue Nov 28, 2024
@blammit
Respect write access in spinbox, date/time selectors and misc buttons
5031002 
Fixes #1764
blammit added a commit that referenced this issue Nov 28, 2024
@blammit
Respect write access in spinbox, date/time selectors and misc buttons
4218f1d 
Fixes #1764
chriadam pushed a commit that referenced this issue Nov 29, 2024
@blammit @chriadam
Respect write access in spinbox, date/time selectors and misc buttons
1c977d3 
Fixes #1764
chriadam pushed a commit that referenced this issue Nov 29, 2024
@blammit @chriadam
Respect write access in spinbox, date/time selectors and misc buttons
9a8ba4a 
Fixes #1764

(cherry picked from commit 3c18855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blammit blammit

Labels
high_prio High priority
Projects
None yet
Milestone
v3.50-fixes
Development

Successfully merging a pull request may close this issue.

Respect write access in spinbox, date/time selectors and misc buttons victronenergy/gui-v2
1 participant
@blammit