Skip to content

Commit b5ba049

Browse files
npentrelnjooma
andauthored
Update get_status signature (#698)
Co-authored-by: Naveed Jooma <[email protected]>
1 parent 2ceb087 commit b5ba049

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

.github/workflows/license_finder.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,27 @@ on:
88

99
jobs:
1010
license_finder:
11-
if: github.repository_owner == 'viamrobotics'
11+
# if: github.repository_owner == 'viamrobotics'
1212
name: Audit 3rd-Party Licenses
1313
runs-on: ubuntu-latest
14-
container:
15-
image: ghcr.io/viamrobotics/canon:amd64-cache
1614
timeout-minutes: 30
1715

1816
steps:
1917
- uses: actions/checkout@v4
2018

2119
- name: Install Poetry
22-
uses: snok/install-poetry@v1
20+
run: pipx install poetry
21+
22+
- name: Setup Python
23+
uses: actions/setup-python@v5
24+
with:
25+
python-version: "3.12"
26+
27+
- uses: ruby/setup-ruby@v1
28+
with:
29+
ruby-version: "3.3"
30+
31+
- run: gem install license_finder
2332

2433
- name: Install package
2534
run: poetry install --all-extras

src/viam/robot/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@
3535
ResourceNamesResponse,
3636
RobotServiceStub,
3737
ShutdownRequest,
38-
StopAllRequest,
39-
StopExtraParameters,
40-
TransformPoseRequest,
41-
TransformPoseResponse,
4238
)
39+
from viam.proto.robot import Status as PBStatus
40+
from viam.proto.robot import StopAllRequest, StopExtraParameters, TransformPoseRequest, TransformPoseResponse
4341
from viam.resource.base import ResourceBase
4442
from viam.resource.manager import ResourceManager
4543
from viam.resource.registry import Registry
@@ -599,7 +597,7 @@ async def __aexit__(self, exc_type, exc_value, traceback):
599597
##########
600598
# STATUS #
601599
##########
602-
async def get_status(self, components: Optional[List[ResourceName]] = None):
600+
async def get_status(self, components: Optional[List[ResourceName]] = None) -> List[PBStatus]:
603601
"""
604602
Get the status of the machine's components. You can optionally
605603
provide a list of ``ResourceName``s for which you want statuses.

0 commit comments

Comments
 (0)