Merge pull request #961 from bhavberi/linting

Fixed all the issues in linting github action

Author: vgrem

.github/workflows/python-app.yml

@@ -42,7 +42,7 @@ jobs:
           pip install -r requirements-dev.txt
       - name: Run Pylint
         run: |
-          pylint office365
+          pylint --disable=too-many-positional-arguments office365
 
   pytest:
     runs-on: ubuntu-latest

office365/runtime/client_object_collection.py

@@ -81,14 +81,12 @@ def remove_child(self, client_object):
 
     def __iter__(self):
         # type: () -> Iterator[T]
-        for item in self._data:
-            yield item
+        yield from self._data
         if self._paged_mode:
             while self.has_next:
                 self._get_next().execute_query()
                 next_items = self._data[self._current_pos :]
-                for next_item in next_items:
-                    yield next_item
+                yield from next_items
 
     def __len__(self):
         # type: () -> int

office365/sharepoint/listitems/listitem.py

@@ -344,7 +344,7 @@ def system_update(self):
 
         def _after_system_update(result):
             # type: (ClientResult[ClientValueCollection[ListItemFormUpdateValue]]) -> None
-            has_any_error = any([item.HasException for item in result.value])
+            has_any_error = any(item.HasException for item in result.value)
             if has_any_error:
                 raise ValueError("Update ListItem failed")
 

office365/sharepoint/lists/list.py

@@ -425,7 +425,7 @@ def get_list_data_as_stream(
         :param ClientResult[dict] return_type: The return type.
         """
         if return_type is None:
-            return_type = ClientResult(context, dict())
+            return_type = ClientResult(context, {})
         payload = {
             "listFullUrl": list_full_url,
             "parameters": parameters,
@@ -451,7 +451,7 @@ def get_onedrive_list_data_as_stream(context, parameters=None, return_type=None)
         :param ClientResult[dict] return_type: The return type.
         """
         if return_type is None:
-            return_type = ClientResult(context, dict())
+            return_type = ClientResult(context, {})
         payload = {
             "parameters": parameters,
         }
@@ -776,7 +776,7 @@ def render_list_data_as_stream(
         :param int render_options: Specifies the type of output to return.
         :param bool expand_groups: Specifies whether to expand the grouping or not.
         """
-        return_type = ClientResult(self.context, dict())
+        return_type = ClientResult(self.context, {})
         if view_xml is None:
             view_xml = "<View/>"
         payload = {

office365/sharepoint/navigation/node.py

@@ -1,12 +1,10 @@
-from typing import TYPE_CHECKING, Optional
+from typing import Optional
 
 from office365.runtime.paths.resource_path import ResourcePath
 from office365.sharepoint.entity import Entity
+from office365.sharepoint.navigation.node_collection import NavigationNodeCollection
 from office365.sharepoint.translation.user_resource import UserResource
 
-if TYPE_CHECKING:
-    from office365.sharepoint.navigation.node_collection import NavigationNodeCollection
-
 
 class NavigationNode(Entity):
     """

office365/sharepoint/webs/web.py

@@ -266,7 +266,7 @@ def get_list_data_as_stream(self, path, view_xml=None):
         """
         if view_xml is None:
             view_xml = "<View><Query></Query></View>"
-        return_type = ClientResult(self.context, dict())
+        return_type = ClientResult(self.context, {})
 
         def _get_list_data_as_stream():
             list_abs_url = self.url + path

office365/teams/schedule/shifts/item.py

@@ -12,5 +12,6 @@ def __init__(self, display_name=None, activities=None):
         :param list[ShiftActivity] activities: An incremental part of a shift which can cover details of when and
             where an employee is during their shift. For example, an assignment or a scheduled break or lunch.
         """
+        super(ShiftItem, self).__init__()
         self.displayName = display_name
         self.activities = ClientValueCollection(ShiftActivity, activities)