Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy indexing #15

Closed
4 tasks done
wooorm opened this issue Dec 21, 2023 · 1 comment
Closed
4 tasks done

Lazy indexing #15

wooorm opened this issue Dec 21, 2023 · 1 comment
Labels
🏁 area/perf This affects performance 💪 phase/solved Post is done

Comments

@wooorm
Copy link
Member

wooorm commented Dec 21, 2023

Initial checklist

Problem

Index is created on startup for the entire document

vfile-location/lib/index.js

Line 77 in e5ee016

indices.push(value.length + 1)
. Perhaps doing unused work.

Solution

Lazily index up to a line number when called.

Alternatives

n/a
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 21, 2023
@wooorm wooorm closed this as completed in 6da1222 Jul 15, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added 🏁 area/perf This affects performance 💪 phase/solved Post is done labels Jul 15, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏁 area/perf This affects performance 💪 phase/solved Post is done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wooorm