Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conventions, templates and CODEOWNERS #244

Closed
wants to merge 314 commits into from
Closed

Conversation

steffenkleinle
Copy link
Member

⚠️ DO NOT MERGE YET ⚠️

Short description

Add conventions, templates and CODEOWNERS.

Proposed changes

  • Add section about conventions to README
  • Add templates for issues and pull requests
  • Add CODEOWNERS file for reviews

Side effects

None.

Testing

Is something missing/would you change something?
Are the github handles correct?

Resolved issues

Fixes: None.


DominikP30 and others added 30 commits February 23, 2023 12:35
Added AccentColor to colorScheme and bodyLarge-TextStyle
Added Slider Carousel for Images, Texts or both
Added slider carousel and more (see in design)
Fixed responsiveness of some widgets
Added more language keys and setSlider-background to transparent
Updated the theme and fixed issues with font-sizes
…ardingScreen-Init

# Conflicts:
#	lib/l10n/app_de.arb
#	lib/screens/intro/intro_screen.dart
#	lib/screens/start/start_screen.dart
#	pubspec.yaml
CODEOWNERS Outdated
# the repo. Unless a later match takes precedence,
# these owners will be requested for
# review when someone opens a pull request.
* @NikoHadouken @volkramweber @steffenkleinle
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know the github handle of Christian?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

His handle is @Stift

@@ -0,0 +1,37 @@
---
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these issue templates are necessary or we want to have some other types of issues. Just copy/pasted. I can also remove them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants