Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong address by default #542

Open
JuliaFreitagBGSt opened this issue Jan 20, 2025 · 5 comments
Open

Wrong address by default #542

JuliaFreitagBGSt opened this issue Jan 20, 2025 · 5 comments
Assignees
Labels
Lead:Pollion For this user story / issue, Pollion has the lead. Type:Bug Something isn't working
Milestone

Comments

@JuliaFreitagBGSt
Copy link

Describe the Bug

In the app, the posters and doors registered in Möhrendorf were marked with the town of Kleinseebach by default, although the posters were not hung up in Kleinseebach but in Möhrendorf.

Steps to Reproduce

  1. Navigate on the map to the postcode 91096 Möhrendorf (near Erlangen)
  2. Enter a door or poster there
  3. See error (it should be Möhrendorf not Kleinseebach by default)
@JuliaFreitagBGSt JuliaFreitagBGSt added Lead:Pollion For this user story / issue, Pollion has the lead. Type:Bug Something isn't working labels Jan 20, 2025
@JuliaFreitagBGSt JuliaFreitagBGSt added this to the Release 1 milestone Jan 20, 2025
@Stift Stift self-assigned this Jan 20, 2025
@Stift
Copy link
Contributor

Stift commented Jan 20, 2025

Not sure whether I would call this a bug. With the API we get some data back and this says it's a village called Kleinseebach.

Image

We could make another call (over the network) to get some more information, and check whether it's a village or a kind of suburb of an area. In most cases the village identifier is correct as we have a isolated settlement in a larger area. As said we can make a second call to re-fine the data, but in most cases this would not give more information.

In most cases where a village belongs to a town a separate field is given, which is called town or city. When this is given, then this identifier is taken over the village identifier. This seems to be special with the OSM data and I would question the OSM data (theoretically).

@JuliaFreitagBGSt
Copy link
Author

Not sure whether I would call this a bug. With the API we get some data back and this says it's a village called Kleinseebach.

Image

We could make another call (over the network) to get some more information, and check whether it's a village or a kind of suburb of an area. In most cases the village identifier is correct as we have a isolated settlement in a larger area. As said we can make a second call to re-fine the data, but in most cases this would not give more information.

In most cases where a village belongs to a town a separate field is given, which is called town or city. When this is given, then this identifier is taken over the village identifier. This seems to be special with the OSM data and I would question the OSM data (theoretically).

Thanks for clarification! What can I report back to the user? That it's an OSM oddity?

@Stift
Copy link
Contributor

Stift commented Jan 20, 2025

For now I would consider this an oddity, which can be solved with some extra logic + effort. Nevertheless we maybe can collect these "issues" in a separate issue with sub-issues to tackle them in a later release in one step. If I would write to the user the message would be:
"Sehr geehrter Nutzer:in
die von uns durchgeführte Adressauflösung ist nur eine Annäherung, die auf den Daten des OpenStreetMap-Projekts basiert. Leider werden alle Adressen in Möhrendorf bei der entsprechenden Rückwärtssuche (Geo-Koordinate ) als Ort 'Kleinseebach' kodiert. Wir werden dies in einer der nächsten Versionen berücksichtigen und versuchen, eine mögliche Lösung zu implementieren.
"

@JuliaFreitagBGSt
Copy link
Author

Great, thank you @Stift :)

@JuliaFreitagBGSt
Copy link
Author

Process: when only "village" is shown, a second request is made, so more information is retrieved @Stift

@Stift Stift changed the title Wrong address by deafult Wrong address by default Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead:Pollion For this user story / issue, Pollion has the lead. Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants