Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the photos in the app #531

Open
JuliaFreitagBGSt opened this issue Jan 13, 2025 · 5 comments
Open

Saving the photos in the app #531

JuliaFreitagBGSt opened this issue Jan 13, 2025 · 5 comments
Labels
BTW: critical Absolutely necessary issues - second order Lead:Pollion For this user story / issue, Pollion has the lead. Type:Enhancement New feature or request
Milestone

Comments

@JuliaFreitagBGSt
Copy link

In the old app, the photos were also saved in the gallery on the phone. Currently this only happens in the app. They cannot be downloaded or shared there. We need that feature again for documentation purposes.

@JuliaFreitagBGSt JuliaFreitagBGSt added Type:Enhancement New feature or request BTW: critical Absolutely necessary issues - second order labels Jan 13, 2025
@JuliaFreitagBGSt JuliaFreitagBGSt added this to the Release 1 milestone Jan 13, 2025
@Stift
Copy link
Contributor

Stift commented Jan 13, 2025

Is this true for the old app? I can't remember this and on my phone which I have for 3 years I have no picture of any old poster. I assume they have been stored in the data directory, but for iPhone don't think this is possible at all or I have to investigate this.
In the most apps if you create a picture on-the-fly (i.e. in the app) - the pic is lost. This is a good feature as the data is normally stored on some server and then downloaded if needed and not consuming storage on the device. which can be massive nowadays.

Should also the mistrials be stored?

@nscharioth nscharioth added the Lead:Pollion For this user story / issue, Pollion has the lead. label Jan 15, 2025
@JuliaFreitagBGSt
Copy link
Author

Sorry, the feedback was misleading. I checked in with the user and could clarify the need:

the original photo from the poster is overwritten by a new photo, e.g. if I mark is as damaged. This is a disadvantage, but it would be helpful if the photos were preserved or could all be found in the gallery in the app.

@Stift Therefore I changed the title of this Issue as well

@JuliaFreitagBGSt JuliaFreitagBGSt changed the title Saving the photos on the device Saving the photos in the app Jan 15, 2025
@Stift
Copy link
Contributor

Stift commented Jan 22, 2025

I think we might need some more details for that.

Let me propose some ideas:

  1. each photo taken is stored on the device (Disadvantage each photo will pile up on the device and I'm quite sure users will complain about that)
  2. a photo can be saved on the device - i.e. a user can click on some photo (maybe a button on the edit_poster or an action in the photo preview)
  3. when a photo is overwritten, the user is asked whether the current photo should be stored

tbh I would prefer the 2nd option as the user has the choice to save the photo before overwriting it. Else I don't see a big advantage, when each photo is stored everytime - most users are casual users and use the app only during an election campaign.

In the future we might have an option to store each picture on the device. Also Option 3 might be in that scope which we can also put in the settings to not annoy the users with popups.

@JuliaFreitagBGSt
Copy link
Author

@Stift The goal is, that several pictures can be saved for one poster entry in the app (not on the device).

Let me clear this up by a use case:

  1. I put up a poster and make a photo, everything is fine, one photo is stored in the app and i shown at the top or on the map in the preview

  2. The poster gets damaged, I see that, mark the poster as damaged and I am able to upload a second photo that shows how severe the damaging is - two photos are stored in the app for this specific poster

  3. I can now decide: is the damage so severe that i would like to replace the poster? Then I remove the label "damaged" and upload a third photo with the new poster hanging up - now three photos are shown in the app (i can see also three by swiping the gallery on the top). OR I can decide based on the photo that the damage is not that severe and keep it as it is.

The idea is, that I can trace the history of the poster with the help of the photos and make decisions for the future of the poster. And only the last uploaded photo is shown primarily a the top resp. preview on the map.

Should also the mistrials be stored? --> No, only the saved pictures.

@Stift
Copy link
Contributor

Stift commented Jan 24, 2025

Understood.
For clarification:

  1. the new_poster function can stay as-is. Only one photo is allowed in the initial creation
  2. the popup shows only the latest photo thumbnail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTW: critical Absolutely necessary issues - second order Lead:Pollion For this user story / issue, Pollion has the lead. Type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants