-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks getting skipped with no explanation #9277
Comments
Hi, thanks for the issue. What directory is |
Here is {
"name": "@riptech/app1",
"private": true,
"scripts": {
"admin": "pnpm --dir=./admin run start",
"api": "pnpm --dir=./api run start",
"client": "pnpm --dir=./client run start",
"landing": "pnpm --dir=./landing run start",
"onboard-demo": "rm -rf $(pwd)/localDBData/demoData && pnpm --dir=./api run onboard-demo",
"start": "concurrently --raw \"pnpm run start-database\" \"pnpm run client\"",
"start-admin": "concurrently --raw \"pnpm run start-database\" \"pnpm run admin\"",
"start-database": "docker-compose up --build",
"stop": "docker-compose down && killall -9 node"
}
} |
Thanks, just to confirm, Judging by your layout, this is likely an issue with nested workspaces. Turborepo doesn't support nested workspaces, i.e. having |
The directory is I don't mean for packages:
- 'apps/*'
- 'apps/*/*'
- 'packages/*/*'
- 'tools/*' If I remove
even though |
Interesting. The behavior you described of running all packages downstream is what should happen. I'll look into that. And possibly improve the error message to show which package json it's trying to pull from |
Is this repository public? Or is it possible to get access to a smaller version of it without any code? |
My repo is private, and very large. If you're willing, I can invite you to the repo temporarily. |
That would be great, thanks! |
@NicholasLYang added you as a collaborator. We can continue discussion in this thread. |
Hi @jakeleventhal, thanks for giving me access! I tried running |
The bug I mentioned is when you remove |
Gotcha. If you delete the |
Right, thats the problem though, I use that package.json as a hub for my project for running npm scripts. I feel like turbo should be able to have ignore paths that I can just specify somehow |
@anthonyshew @NicholasLYang is this going to be implemented as a feature? |
Verify canary release
Link to code that reproduces this issue
See output
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
[email protected]
Describe the Bug
For some reason, I am getting tasks that seem to skip with no explanation. In a directory of my application
apps/app1/api
, I runturbo tsc
and expect 15 total tasks to be ran. It seems that turbo randomly only does a subset of tasks. If I runturbo tsc
several times in a row, I randomly will get correct output:and randomly get incorrect output that does not download cached outputs:
Notably, see how it says:
I don't even have a tsc task for
@riptech/app1
Expected Behavior
In all cases, I would expect all 15 tasks to run (cached).
To Reproduce
See above
Additional context
Here is my turbo.json
The text was updated successfully, but these errors were encountered: