cocli has broken backwards compatibility

[lordaule]

The "old" cocli, downloaded via the instructions at README.md

go install github.com/veraison/cocli@latest

was able to decode .cbor files provided by vendors, provided the first 6 bytes - the IANA vendor tags from the earlier draft spec - were removed.

Many vendors include these instructions on their websites. Here are just 2:
https://www.solidigm.com/support-page/drivers-downloads/ka-01851.html
https://docs.nvidia.com/networking/display/dpunicattestation/example+commands

If you download the example cbor files from the vendors above
Solidigm: https://sdmsdfwdriver.blob.core.windows.net/files/kba-gcc/drivers-downloads/ka-01851/ps10xx-e3s-2tb-cbor.zip
Nvidia: curl -s 'https://rim.attestation.nvidia.com/v1/rim/NV_NIC_FIRMWARE_CX7_28.44.1036_MCX755106AS-HEA' | jq -r '.rim' | base64 -d > NV_NIC_FIRMWARE_CX7_28.44.1036_MCX755106AS-HEA.cbor

cocli claims the above files are invalid:

cocli corim display -f NV_NIC_FIRMWARE_CX7_28.44.1036_MCX755106AS-HEA.cbor
Error: error decoding CoRIM (signed or unsigned) from NV_NIC_FIRMWARE_CX7_28.44.1036_MCX755106AS-HEA.cbor: did not see unsigned CoRIM tag

For reference, with the prior cocli, following the trimming instructions, these files were printable with cocli:

1. trim the leading 6 bytes as the vendors indicate:
   dd bs=1 skip=6 if= of=<untagged.corim>

2. use old cocli to decode the untagged file:
   cocli corim display -f NV_NIC_FIRMWARE_CX7_28.44.1036_MCX755106AS-HEA.cbor-untagged -v |grep id
   "corim-id": "ConnectX-7_28.44.1036",
   "href": "https://docs.ndis.nvidia.com/certs/corim/nvidia-corim-signer-cx7-id-2.pem",
   "tag-identity": {
   "id": "15b3102115b3002200-28.44.1036"

cocli needs to be backwards compatible and support all of these existing published .cbor files that vendors have already distributed

[thomas-fossati]

Hi @lordaule, while we didn’t promise backwards compatibility, I appreciate that the current situation is annoying.

To be entirely clear, at this time, CoRIM is just an “Internet Draft”, not a full standard, and as such:

[…] Internet-Drafts (often referred to simply as "drafts") have no formal status, and are subject to change or removal at any time; therefore they should not be cited or quoted in any formal document.

In any case, could you please try out the updated instructions and let me know if they work for you?

[lordaule]

I have tried the updated instructions, but this requires us to create a wrapper script around cocli, that basically does:

try current cocli on filename
  failure?  try old cocli on filename

So while cocli itself doesn't promise backwards compatibility, users absolutely require it, to be able to work with the CoRIM files published by multiple vendors.

Instead of every single cocli user have to write their own wrapper script, it would save everyone a lot of work if cocli performed this step itself.