Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPack/Installer should copy vegastrike.config into $HOME/.vegastrike #26

Open
stephengtuggy opened this issue Feb 7, 2021 · 7 comments

Comments

@stephengtuggy
Copy link

Describe the bug
The installer doesn't currently copy the vegastrike.config file into ~/.vegastrike, only into /usr/share/vegastrike. So users have to copy it manually, or use another method to get the file into the proper directory.

To Reproduce

  1. Install the Vega Strike engine, v0.7.0 beta 10, followed by the Assets beta.
  2. Try running vegastrike or vsettings.

Expected behavior
There should already be a default vegastrike.config file in the $HOME/.vegastrike directory to start with. Both vsettings and vegastrike binaries should "just work" with that file, albeit with some limitations in terms of graphics resolution, etc.

Please complete the following information):

  • OS: Reported on Ubuntu 20.04 LTS.
  • Software Versions: Reported with v0.7.0-beta10

Additional context
Originally reported as vegastrike/Vega-Strike-Engine-Source#417 (comment)
Then filed as vegastrike/Vega-Strike-Engine-Source#420
Moving the issue to the correct (I think) repository.

@BenjamenMeyer
Copy link
Member

I'm not sure this is something the installer can do; rather the default probably should be at (for example) /usr/share/vegastrike/config, and then copied over to the user's profile (~/.vegastrike) only when saved.

Reason being: the installer doesn't know anything about the user, especially on Linux; and we should try to be consistent across platforms.

@stephengtuggy
Copy link
Author

Hmm. I see your point.

I guess this raises another question: Should Vega Strike / vsUTCS be a system-wide installation? A per-user installation? Should they support both configurations?

@BenjamenMeyer
Copy link
Member

@stephengtuggy yes it should be system wide by design; though the user's installation system (at least on Windows) may offer a user-only type installation. I don't think Linux Package Managers typically provide for a user-specific install. Not sure about Mac. AFAIK only Windows does, but even then it might fall to the installer to decide if that's an option (likely) in which case we should support it if we could.

@stephengtuggy
Copy link
Author

Filed a follow-up issue, vegastrike/Assets-Production#50

@BenjamenMeyer
Copy link
Member

We need to get 0.7.x out the door; deferring this as it'll be more research oriented to determine an answer

@BenjamenMeyer
Copy link
Member

as we're getting ready to release 0.7.0 and we want a fast turn around on 0.8.x i'm deferring this to 0.9.x

@BenjamenMeyer BenjamenMeyer transferred this issue from vegastrike/Assets-Production Jun 8, 2021
@BenjamenMeyer
Copy link
Member

system-wide vs user installation is #27 but that ultimately comes down to what the system is capable of (Linux distros don't often support user-only installs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants