Skip to content

Commit 91679d8

Browse files
committed
update to cli 0.2.2, ember 1.11 and convert syntax to work with disable-prototype-extensions
1 parent 962aa7a commit 91679d8

File tree

8 files changed

+36
-37
lines changed

8 files changed

+36
-37
lines changed

LICENSE

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) [year] [fullname]
3+
Copyright (c) 2015
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal
@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
1818
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
1919
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2020
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21-
SOFTWARE.
21+
SOFTWARE.

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[![Build Status](https://travis-ci.org/aomra015/ember-cli-chart.svg)](https://travis-ci.org/aomra015/ember-cli-chart)
44

5-
This is an Ember CLI addon for adding a [ChartJS](http://www.chartjs.org/) component. This addon is tested on Ember-CLI v0.2.1 and uses the `ember-try` addon to test against multiple Ember versions.
5+
This is an Ember CLI addon for adding a [ChartJS](http://www.chartjs.org/) component. This addon is tested on Ember-CLI v0.2.2 and uses the `ember-try` addon to test against multiple Ember versions.
66

77
### Installation
88

addon/components/ember-chart.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ export default Ember.Component.extend({
66
tagName: 'canvas',
77
attributeBindings: ['width', 'height'],
88

9-
renderChart: function(){
9+
didInsertElement: function(){
1010
var context = this.get('element').getContext('2d');
1111
var data = this.get('data');
12-
var type = this.get('type').classify();
12+
var type = Ember.String.classify(this.get('type'));
1313
var options = Ember.merge({}, this.get('options'));
1414

1515
var chart = new Chart(context)[type](data, options);
@@ -20,17 +20,17 @@ export default Ember.Component.extend({
2020
}
2121

2222
this.set('chart', chart);
23-
}.on('didInsertElement'),
23+
},
2424

25-
destroyChart: function(){
25+
willDestroyElement: function(){
2626
if (this.get('legend')) {
2727
this.$().parent().children('[class$=legend]').remove();
2828
}
2929

3030
this.get('chart').destroy();
31-
}.on('willDestroyElement'),
31+
},
3232

33-
updateChart: function(){
33+
updateChart: Ember.observer('data', 'data.[]', 'options', function(){
3434
var chart = this.get('chart');
3535
var data = this.get('data');
3636
var needUpdate = ChartDataUpdater.create({
@@ -39,5 +39,5 @@ export default Ember.Component.extend({
3939
}).updateByType();
4040

4141
if (needUpdate) { chart.update(); }
42-
}.observes('data', 'data.[]', 'options')
42+
})
4343
});

bower.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
"name": "ember-cli-chart",
33
"dependencies": {
44
"jquery": "^1.11.1",
5-
"ember": "1.10.0",
6-
"ember-data": "1.0.0-beta.16",
7-
"ember-resolver": "~0.1.14",
5+
"ember": "1.11.0",
6+
"ember-data": "1.0.0-beta.16.1",
7+
"ember-resolver": "~0.1.15",
88
"loader.js": "ember-cli/loader.js#3.2.0",
99
"ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
1010
"ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
1111
"ember-load-initializers": "ember-cli/ember-load-initializers#0.0.2",
12-
"ember-qunit": "0.2.8",
12+
"ember-qunit": "0.3.0",
1313
"ember-qunit-notifications": "0.0.7",
1414
"qunit": "~1.17.1",
1515
"chartjs": "1.0.1"

package.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"homepage": "https://github.com/aomra015/ember-cli-chart",
3232
"devDependencies": {
3333
"broccoli-asset-rev": "^2.0.2",
34-
"ember-cli": "^0.2.1",
34+
"ember-cli": "0.2.2",
3535
"ember-cli-app-version": "0.3.3",
3636
"ember-cli-content-security-policy": "0.4.0",
3737
"ember-cli-dependency-checker": "0.0.8",
@@ -40,9 +40,10 @@
4040
"ember-cli-inject-live-reload": "^1.3.0",
4141
"ember-cli-qunit": "0.3.9",
4242
"ember-cli-uglify": "1.0.1",
43-
"ember-data": "1.0.0-beta.16",
43+
"ember-data": "1.0.0-beta.16.1",
4444
"ember-export-application-global": "^1.0.2",
45-
"ember-try": "0.0.1"
45+
"ember-disable-prototype-extensions": "^1.0.0",
46+
"ember-try": "0.0.4"
4647
},
4748
"dependencies": {
4849
"ember-cli-babel": "^4.0.0"

tests/dummy/app/controllers/application.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export default Ember.Controller.extend({
44
pieValue1: 300,
55
pieValue2: 50,
66
pieValue3: 100,
7-
pieData: function(){
7+
pieData: Ember.computed('pieValue1', 'pieValue2', 'pieValue3', function(){
88
return [
99
{
1010
value: parseInt(this.get('pieValue1')),
@@ -25,10 +25,10 @@ export default Ember.Controller.extend({
2525
label: "Yellow"
2626
}
2727
];
28-
}.property('pieValue1', 'pieValue2', 'pieValue3'),
29-
lineValue1: 65,
28+
}),
29+
lineValue1: 65,
3030
lineValue2: 59,
31-
lineData: function(){
31+
lineData: Ember.computed('lineValue1', 'lineValue2', function(){
3232
return {
3333
labels: ["January", "February", "March", "April", "May", "June", "July"],
3434
datasets: [
@@ -54,8 +54,8 @@ export default Ember.Controller.extend({
5454
}
5555
]
5656
};
57-
}.property('lineValue1', 'lineValue2'),
58-
barData: {
57+
}),
58+
barData: {
5959
labels: ["January", "February", "March", "April", "May", "June", "July"],
6060
datasets: [
6161
{
@@ -75,8 +75,8 @@ export default Ember.Controller.extend({
7575
data: [28, 48, 40, 19, 86, 27, 90]
7676
}
7777
]
78-
},
79-
radarData: {
78+
},
79+
radarData: {
8080
labels: ["Eating", "Drinking", "Sleeping", "Designing", "Coding", "Cycling", "Running"],
8181
datasets: [
8282
{
@@ -100,8 +100,8 @@ export default Ember.Controller.extend({
100100
data: [28, 48, 40, 19, 96, 27, 100]
101101
}
102102
]
103-
},
104-
polarAreaData: [
103+
},
104+
polarAreaData: [
105105
{
106106
value: 300,
107107
color:"#F7464A",
@@ -133,5 +133,5 @@ export default Ember.Controller.extend({
133133
label: "Dark Grey"
134134
}
135135

136-
]
136+
]
137137
});

tests/dummy/app/router.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@ var Router = Ember.Router.extend({
55
location: config.locationType
66
});
77

8-
Router.map(function() {
8+
export default Router.map(function() {
99
});
10-
11-
export default Router;

tests/unit/components/ember-chart-test.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ var ChartTestData = Ember.Object.extend({
1111
pieValue1: 300,
1212
pieValue2: 50,
1313
pieValue3: 100,
14-
pieData: function(){
14+
pieData: Ember.computed('pieValue1', 'pieValue2', 'pieValue3', function(){
1515
return [
1616
{
1717
value: parseInt(this.get('pieValue1')),
@@ -32,9 +32,9 @@ var ChartTestData = Ember.Object.extend({
3232
label: "Yellow"
3333
}
3434
];
35-
}.property('pieValue1', 'pieValue2', 'pieValue3'),
35+
}),
3636

37-
pieData2: function(){
37+
pieData2: Ember.computed(function(){
3838
return [
3939
{
4040
value: 300,
@@ -61,11 +61,11 @@ var ChartTestData = Ember.Object.extend({
6161
label: "Black"
6262
}
6363
];
64-
}.property(),
64+
}),
6565

6666
lineValue1: 65,
6767
lineValue2: 59,
68-
lineData: function(){
68+
lineData: Ember.computed('lineValue1', 'lineValue2', function(){
6969
return {
7070
labels: ["January", "February", "March", "April", "May", "June", "July"],
7171
datasets: [
@@ -91,7 +91,7 @@ var ChartTestData = Ember.Object.extend({
9191
}
9292
]
9393
};
94-
}.property('lineValue1', 'lineValue2')
94+
})
9595
});
9696

9797
var testData = ChartTestData.create();

0 commit comments

Comments
 (0)