Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FailedToApplyFilter Error in parse_grok() improvements #1119

Open
neuronull opened this issue Nov 11, 2024 · 0 comments
Open

FailedToApplyFilter Error in parse_grok() improvements #1119

neuronull opened this issue Nov 11, 2024 · 0 comments
Labels
type: enhancement A value-adding code change that enhances its existing functionality type: tech debt A code change that does not add user value

Comments

@neuronull
Copy link
Contributor

During #1113 , some changes were proposed to the Error types and it was observed that the FailedToApply filter covers a lot of distinct cases and also hides the underlying error.

We should consider:

  • surfacing the underlying error
  • expanding the catch all type to distinct variants that cover each scenario.
@neuronull neuronull added type: enhancement A value-adding code change that enhances its existing functionality type: tech debt A code change that does not add user value labels Nov 11, 2024
@neuronull neuronull mentioned this issue Nov 11, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A value-adding code change that enhances its existing functionality type: tech debt A code change that does not add user value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neuronull