Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thorest package to point to v2 core sdk package #1753

Open
saraantole opened this issue Jan 28, 2025 · 1 comment · Fixed by #1755
Open

Fix thorest package to point to v2 core sdk package #1753

saraantole opened this issue Jan 28, 2025 · 1 comment · Fixed by #1755
Assignees

Comments

@saraantole
Copy link
Collaborator

saraantole commented Jan 28, 2025

Summary

In the development of thorest package v2, we are currently importing modules from v1 using the published NPM packages. However, this causes issues when making changes to these packages in v2 because the imports resolve locally instead of pulling from the NPM package.

To resolve this, we need to update the package.json files to point to core package v2 instead of using the v1. This ensures that changes made to the dependencies in the v2 branch are properly reflected in our development environment.

Tasks:

  • Update all relevant package.json files to reference the v2 for dependencies instead of v1
  • Ensure that dependencies resolve correctly and that local development workflows remain functional.
  • Test the changes to confirm they work as expected.

Expected Outcome:
Dependencies should correctly pull from the v2 core sdk package, allowing us to develop and test changes without conflicts caused by local resolution.

@saraantole saraantole added this to the 2.0.0-beta (Pre-Release) milestone Jan 28, 2025
@saraantole saraantole self-assigned this Jan 28, 2025
@saraantole saraantole changed the title Patch sdk packages to point to feature-thorest branch Fix thorest module to point to v2 core sdk package Jan 28, 2025
@saraantole saraantole changed the title Fix thorest module to point to v2 core sdk package Fix thorest package to point to v2 core sdk package Jan 28, 2025
@saraantole
Copy link
Collaborator Author

See PR

@saraantole saraantole linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant