fix tests

Author: mumoshu

Makefile

@@ -8,7 +8,7 @@ build:
 	go build -o bin/actions ./cmd
 
 test:
-	echo
+	go test ./...
 
 # Run this like: SOURCE_BRANCH= make build/docker so that you can build the `latest` from a commit that is not tagged yet
 build/docker: SOURCE_BRANCH ?= v1.2.3

cmd/checks/checks.go

@@ -9,7 +9,7 @@ import (
 )
 
 func main() {
-	cmd := exec.New()
+	cmd := checks.New()
 
 	fs := flag.CommandLine
 	fs.Init("checks", flag.ExitOnError)

pkg/pullvet/pullvet.go

@@ -30,6 +30,8 @@ type Command struct {
 	anyMilestone bool
 	requireAny   bool
 	requireAll   bool
+
+	getPullRequestBody func(string, string, int) (string, error)
 }
 
 func normalizeNewlines(str string) string {
@@ -38,6 +40,7 @@ func normalizeNewlines(str string) string {
 
 func New() *Command {
 	return &Command{
+		getPullRequestBody: GetPullRequestBody,
 	}
 }
 
@@ -112,25 +115,11 @@ func (c *Command) HandlePullRequest(owner, repo string, pullRequest *github.Pull
 	var body string
 
 	if owner != "" {
-		client, err := actions.CreateInstallationTokenClient(os.Getenv("GITHUB_TOKEN"), "", "")
-		if err != nil {
-			return err
-		}
-
-		pr, _, err := client.PullRequests.Get(context.Background(), owner, repo, pullRequest.GetNumber())
+		var err error
+		body, err = c.getPullRequestBody(owner, repo, pullRequest.GetNumber())
 		if err != nil {
 			return err
 		}
-
-		buf := bytes.Buffer{}
-		enc := json.NewEncoder(&buf)
-		enc.SetIndent("", "  ")
-		if err := enc.Encode(pr); err != nil {
-			return err
-		}
-		log.Printf("Pull request:\n%s", buf.String())
-
-		body = pr.GetBody()
 	} else {
 		body = pullRequest.GetBody()
 	}
@@ -168,6 +157,28 @@ func (c *Command) HandlePullRequest(owner, repo string, pullRequest *github.Pull
 	return nil
 }
 
+func GetPullRequestBody(owner, repo string, prNumber int) (string, error) {
+	client, err := actions.CreateInstallationTokenClient(os.Getenv("GITHUB_TOKEN"), "", "")
+	if err != nil {
+		return "", err
+	}
+
+	pr, _, err := client.PullRequests.Get(context.Background(), owner, repo, prNumber)
+	if err != nil {
+		return "", err
+	}
+
+	buf := bytes.Buffer{}
+	enc := json.NewEncoder(&buf)
+	enc.SetIndent("", "  ")
+	if err := enc.Encode(pr); err != nil {
+		return "", err
+	}
+	log.Printf("Pull request:\n%s", buf.String())
+
+	return pr.GetBody(), nil
+}
+
 func formatFailures(failures []string) string {
 	var lines []string
 	for _, f := range failures {

pkg/pullvet/pullvet_test.go

@@ -88,48 +88,54 @@ func TestNoteRegex(t *testing.T) {
 }
 
 func TestRun(t *testing.T) {
+	stubPRBody := func(body string) func(owner, repo string, num int) (string, error) {
+		return func(owner, repo string, num int) (string, error) {
+			return body, nil
+		}
+	}
+
 	testcases := []struct {
 		cmd      *Command
 		input    *github.PullRequest
 		expected string
 	}{
 		{
-			cmd:      &Command{requireAny: true, labels: []string{"v1"}},
+			cmd:      &Command{requireAny: true, labels: []string{"v1"}, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Labels: []*github.Label{&github.Label{Name: github.String("v1")}}},
 			expected: "",
 		},
 		{
-			cmd:      &Command{requireAny: true, labels: []string{"v2"}},
+			cmd:      &Command{requireAny: true, labels: []string{"v2"}, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Labels: []*github.Label{&github.Label{Name: github.String("v1")}}},
 			expected: "1 check(s) failed:\n* missing label: v2",
 		},
 		{
-			cmd:      &Command{requireAny: true, labels: []string{"v2", "v3"}},
+			cmd:      &Command{requireAny: true, labels: []string{"v2", "v3"}, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Labels: []*github.Label{&github.Label{Name: github.String("v1")}}},
 			expected: "2 check(s) failed:\n* missing label: v2\n* missing label: v3",
 		},
 		{
-			cmd:      &Command{requireAny: true, milestone: "v1"},
+			cmd:      &Command{requireAny: true, milestone: "v1", noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Milestone: &github.Milestone{Title: github.String("v1")}},
 			expected: "",
 		},
 		{
-			cmd:      &Command{requireAny: true, anyMilestone: true},
+			cmd:      &Command{requireAny: true, anyMilestone: true, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Milestone: &github.Milestone{Title: github.String("v1")}},
 			expected: "",
 		},
 		{
-			cmd:      &Command{requireAny: true, milestone: "v2"},
+			cmd:      &Command{requireAny: true, milestone: "v2", noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{Milestone: &github.Milestone{Title: github.String("v1")}},
 			expected: "1 check(s) failed:\n* unexpected milestone: expected \"v2\", got \"v1\"",
 		},
 		{
-			cmd:      &Command{requireAny: true, anyMilestone: true},
+			cmd:      &Command{requireAny: true, anyMilestone: true, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input:    &github.PullRequest{},
 			expected: "1 check(s) failed:\n* missing milestone",
 		},
 		{
-			cmd: &Command{requireAny: true, labels: []string{"v2", "v3"}},
+			cmd: &Command{requireAny: true, labels: []string{"v2", "v3"}, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input: &github.PullRequest{
 				Labels: []*github.Label{
 					&github.Label{Name: github.String("v2")},
@@ -139,7 +145,7 @@ func TestRun(t *testing.T) {
 			expected: "",
 		},
 		{
-			cmd: &Command{requireAll: true, labels: []string{"v2", "v3"}},
+			cmd: &Command{requireAll: true, labels: []string{"v2", "v3"}, noteRegex: defaultNoteRegex, getPullRequestBody: stubPRBody("")},
 			input: &github.PullRequest{
 				Labels: []*github.Label{
 					&github.Label{Name: github.String("v2")},
@@ -153,7 +159,7 @@ func TestRun(t *testing.T) {
 	for i := range testcases {
 		tc := testcases[i]
 
-		err := tc.cmd.HandlePullRequest("", "", tc.input)
+		err := tc.cmd.HandlePullRequest("myuser", "myrepo", tc.input)
 
 		if tc.expected != "" && !strings.Contains(err.Error(), tc.expected) {
 			t.Errorf("unexpected error: expected=%q, got=%q", tc.expected, err)