Skip to content

Commit 8d11901

Browse files
committed
fix(exec): do not panic on too short summary
1 parent 882de4c commit 8d11901

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pkg/exec/exec.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,11 @@ func (c *Command) EnsureCheckRun(pre *github.PullRequestEvent) error {
166166
desc = summary
167167
}
168168

169-
// Otherwise you get errors like:
170-
// 2019/10/17 18:25:08 Failed creating status: POST https://api.github.com/repos/variantdev/go-actions/statuses/ceb4320db3c54081d55daa6d7a50ed8dc7fafc86: 422 Validation Failed [{Resource:Status Field:description Code:custom Message:description is too long (maximum is 140 characters)}]
171-
desc = desc[0:140]
169+
if len(desc) > 140 {
170+
// Otherwise you get errors like:
171+
// 2019/10/17 18:25:08 Failed creating status: POST https://api.github.com/repos/variantdev/go-actions/statuses/ceb4320db3c54081d55daa6d7a50ed8dc7fafc86: 422 Validation Failed [{Resource:Status Field:description Code:custom Message:description is too long (maximum is 140 characters)}]
172+
desc = desc[0:140]
173+
}
172174

173175
status := &github.RepoStatus{
174176
State: github.String(state),

0 commit comments

Comments
 (0)