fix(exec): support issues event on pull request

Author: mumoshu

Makefile

@@ -8,7 +8,8 @@ build:
 	go build -o bin/actions ./cmd
 
 test/integration:
-	GITHUB_EVENT_NAME=issues GITHUB_EVENT_PATH=testdata/issues_event.json bin/actions pullvet
+	echo aaa
+	GITHUB_EVENT_NAME=issues GITHUB_EVENT_PATH=testdata/issues_event.json bin/actions exec -status-context milestone -- bin/actions pullvet -require-any -milestone-match 'test-v.+' label milestone/none
 
 test:
 	go test ./...

event.go

@@ -72,6 +72,26 @@ func IssueEvent() (*github.IssuesEvent, error) {
 	return evt.(*github.IssuesEvent), nil
 }
 
+func GetPullRequest(issue *github.IssuesEvent) (*github.PullRequest, error) {
+	client, err := CreateInstallationTokenClient(os.Getenv("GITHUB_TOKEN"), "", "")
+	if err != nil {
+		return nil, err
+	}
+
+	if issue.Issue.GetPullRequestLinks().GetURL() == "" {
+		return nil, fmt.Errorf("issue %d is not a pull request", issue.Issue.GetNumber())
+	}
+
+	// This can be a pull_request milestoned/demilestoned events emitted as issue event
+	owner := issue.Repo.Owner.GetLogin()
+	repo := issue.Repo.GetName()
+	pull, _, err := client.PullRequests.Get(context.Background(), owner, repo, issue.Issue.GetNumber())
+	if err != nil {
+		return nil, err
+	}
+	return pull, nil
+}
+
 func PullRequest() (*github.PullRequest, string, string, error) {
 	var pr *github.PullRequest
 	var owner, repo string
@@ -82,22 +102,11 @@ func PullRequest() (*github.PullRequest, string, string, error) {
 			return nil, "", "", err
 		}
 
-		client, err := CreateInstallationTokenClient(os.Getenv("GITHUB_TOKEN"), "", "")
+		pull, err := GetPullRequest(issue)
 		if err != nil {
 			return nil, "", "", err
 		}
 
-		if issue.Issue.GetPullRequestLinks().GetURL() == "" {
-			return nil, "", "", fmt.Errorf("issue %d is not a pull request", issue.Issue.GetNumber())
-		}
-
-		// This can be a pull_request milestoned/demilestoned events emitted as issue event
-		owner := issue.Repo.Owner.GetLogin()
-		repo := issue.Repo.GetName()
-		pull, _, err := client.PullRequests.Get(context.Background(), owner, repo, issue.Issue.GetNumber())
-		if err != nil {
-			return nil, "", "", err
-		}
 		pr = pull
 	case "pull_request":
 		pull, err := PullRequestEvent()

pkg/exec/exec.go

@@ -28,6 +28,11 @@ type Command struct {
 	args []string
 }
 
+type Target struct {
+	Owner, Repo string
+	PullRequest *github.PullRequest
+}
+
 func New() *Command {
 	return &Command{
 		BaseURL:   "",
@@ -62,8 +67,26 @@ func (c *Command) Run(args []string) error {
 
 func (c *Command) HandleEvent(payload interface{}) error {
 	switch e := payload.(type) {
+	case *github.IssuesEvent:
+		pull, err := actions.GetPullRequest(e)
+		if err != nil {
+			return err
+		}
+		target := &Target{
+			Owner: e.Repo.Owner.GetLogin(),
+			Repo: e.Repo.GetName(),
+			PullRequest: pull,
+		}
+		return c.EnsureCheckRun(target)
 	case *github.PullRequestEvent:
-		return c.EnsureCheckRun(e)
+		owner := e.Repo.Owner.GetLogin()
+		repo := e.Repo.GetName()
+		target := &Target{
+			Owner: owner,
+			Repo: repo,
+			PullRequest: e.PullRequest,
+		}
+		return c.EnsureCheckRun(target)
 	}
 	return nil
 }
@@ -96,7 +119,7 @@ func (c *Command) createCheckRun(suite *github.CheckSuite, cr Run) (*github.Chec
 	return created, err
 }
 
-func (c *Command) EnsureCheckRun(pre *github.PullRequestEvent) error {
+func (c *Command) EnsureCheckRun(pre *Target) error {
 	client, err := c.instTokenClient()
 	if err != nil {
 		return err
@@ -106,8 +129,8 @@ func (c *Command) EnsureCheckRun(pre *github.PullRequestEvent) error {
 
 	summary, text, runErr := c.runIt()
 
-	owner := pre.Repo.Owner.GetLogin()
-	repo := pre.Repo.GetName()
+	owner := pre.Owner
+	repo := pre.Repo
 
 	if c.checkRunName != "" {
 		suite, err := c.EnsureCheckSuite(pre)
@@ -212,7 +235,7 @@ func (c *Command) logCheckRun(checkRun *github.CheckRun) {
 	log.Printf("CheckRun:\n%s", buf.String())
 }
 
-func (c *Command) EnsureCheckSuite(pre *github.PullRequestEvent) (*github.CheckSuite, error) {
+func (c *Command) EnsureCheckSuite(pre *Target) (*github.CheckSuite, error) {
 	return c.getOneOfSuitesAlreadyCreatedByGitHubActions(pre)
 }
 
@@ -288,13 +311,13 @@ func (c *Command) logResponseAndError(suites *github.ListCheckSuiteResults, res
 	return nil
 }
 
-func (c *Command) getOneOfSuitesAlreadyCreatedByGitHubActions(pre *github.PullRequestEvent) (*github.CheckSuite, error) {
+func (c *Command) getOneOfSuitesAlreadyCreatedByGitHubActions(pre *Target) (*github.CheckSuite, error) {
 	client, err := c.instTokenClient()
 	if err != nil {
 		return nil, fmt.Errorf("Failed to create a new installation token client: %s", err)
 	}
 
-	owner, repo := pre.GetRepo().GetOwner().GetLogin(), pre.GetRepo().GetName()
+	owner, repo := pre.Owner, pre.Repo
 
 	sha := pre.PullRequest.Head.GetSHA()