[Fix] update code based on comments from @lishid

See obsidianmd/obsidian-releases#330

Author: vanadium23

manifest.json

@@ -1,8 +1,8 @@
 {
 	"id": "obsidian-advanced-new-file",
 	"name": "Advanced new file",
-	"version": "1.0.0",
-	"minAppVersion": "0.9.12",
+	"version": "1.0.1",
+	"minAppVersion": "0.9.7",
 	"description": "This is a plugin for choosing folder on note creation.",
 	"author": "vanadium23",
 	"authorUrl": "https://vanadium23.me/",

src/main.ts

@@ -9,15 +9,8 @@ export default class AdvancedNewFilePlugin extends Plugin {
 		this.addCommand({
 			id: 'advanced-new-file',
 			name: 'Create note',
-			checkCallback: (checking: boolean) => {
-				let leaf = this.app.workspace.activeLeaf;
-				if (leaf) {
-					if (!checking) {
-						new ChooseFolderModal(this.app).open();
-					}
-					return true;
-				}
-				return false;
+			callback: () => {
+				new ChooseFolderModal(this.app).open();
 			}
 		});
 	}

src/modal.ts

@@ -1,4 +1,4 @@
-import { App, FuzzySuggestModal, TFolder, Notice } from 'obsidian';
+import { App, FuzzySuggestModal, TFolder, Notice, Vault } from 'obsidian';
 
 const EMPTY_TEXT = 'No files found to append content. Enter to create a new one.'
 const PLACEHOLDER_TEXT = 'Type file to append to or create';
@@ -20,11 +20,12 @@ export class ChooseFolderModal extends FuzzySuggestModal<TFolder>{
     }
 
     init() {
-        const files = this.app.vault.getFiles();
 		const folders = new Set() as Set<TFolder>;
-		for (const file of files) {
-			folders.add(file.parent)
-		}
+        Vault.recurseChildren(this.app.vault.getRoot(), (file) => {
+            if (file instanceof TFolder) {
+                folders.add(file);
+            }
+        });
 		this.folders = Array.from(folders);
         this.emptyStateText = EMPTY_TEXT;
         this.setPlaceholder(PLACEHOLDER_TEXT);
@@ -84,7 +85,7 @@ export class ChooseFolderModal extends FuzzySuggestModal<TFolder>{
             const file = await this.app.vault.create(fileName, "");
             this.app.workspace.activeLeaf.openFile(file);
           } catch (error) {
-              new Notice(error);
+              new Notice(error.toString());
           }
       }
 

versions.json

@@ -1,3 +1,4 @@
 {
+	"1.0.1": "0.9.7",
 	"1.0.0": "0.9.7"
 }