fix: process termination

Author: angrybayblade

.pylintrc

@@ -20,7 +20,7 @@ E0611: no-name-in-module
 R0903: Too few public methods
 
 [IMPORTS]
-ignored-modules=os,io
+ignored-modules=os,io,psutil
 
 [DESIGN]
 # min-public-methods=1

operate/services/service.py

@@ -32,6 +32,7 @@
 from pathlib import Path
 from venv import main as venv_cli
 
+import psutil
 from aea.__version__ import __version__ as aea_version
 from aea.configurations.constants import (
     DEFAULT_LEDGER,
@@ -428,7 +429,15 @@ def _start_tendermint(working_dir: Path) -> None:
 
 def _kill_process(pid: int) -> None:
     """Kill process."""
+    print(f"Trying to kill process: {pid}")
     while True:
+        if not psutil.pid_exists(pid=pid):
+            return
+        if psutil.Process(pid=pid).status() in (
+            psutil.STATUS_DEAD,
+            psutil.STATUS_ZOMBIE,
+        ):
+            return
         try:
             os.kill(
                 pid,
@@ -440,7 +449,7 @@ def _kill_process(pid: int) -> None:
             )
         except OSError:
             return
-        time.sleep(3)
+        time.sleep(1)
 
 
 def _stop_agent(working_dir: Path) -> None:

poetry.lock

@@ -43,6 +43,7 @@ requests-toolbelt = "1.0.0"
 starlette = "==0.36.3"
 uvicorn = "==0.27.0"
 web3 = "==6.1.0"
+psutil = "^5.9.8"
 
 [build-system]
 requires = ["poetry-core"]

pyproject.toml

@@ -212,3 +212,6 @@ ignore_missing_imports = True
 
 [mypy-werkzeug.*]
 ignore_missing_imports = True
+
+[mypy-psutil.*]
+ignore_missing_imports = True