README.md

Internal audit of autonolas-tokenomics

The review has been performed based on the contract code in the following repository:
https://github.com/valory-xyz/autonolas-tokenomics
commit: c14746b4ddc2f7cf6db8a566b47b0dc596212a94 or tag: v1.3.1-pre-internal-audit

Objectives

The audit focused on changes in tokonomics contract in this repo.

Storage and proxy

Using sol2uml tools: https://github.com/naddison36/sol2uml

sol2uml storage contracts/ -f png -c Tokenomics -o audits/internal6/
Generated png file audits/internal6/Tokenomics.png

From the point of view of auditing a proxy contract, only storage are important: Tokenomics.
Tokenomics-storage - 17 slots
Current contract storage Tokenomics-storage - 17 slots
OK.

Security issues.

Medium/Notes. Re-math for updateInflation

Perhaps a more complex algorithm is needed so that the staking limit is not exceeded in the year of the change. To discussion.

[x] Fixed

Medium/Notes. Not fixed TODO

grep -r TODO ./contracts/
./contracts/TokenomicsConstants.sol:            // TODO Shall it be 787_991_346e18 as a starting number?
./contracts/TokenomicsConstants.sol:            // TODO Shall it be 787_991_346e18 as a starting number?
./contracts/TokenomicsConstants.sol:            // TODO Shall it be 761_726_593e18 as a starting number?
./contracts/TokenomicsConstants.sol:            // TODO Shall it be 761_726_593e18 as a starting number?

[x] Fixed

Low/Notes. Update version?

abstract contract TokenomicsConstants {
    // Tokenomics version number
    string public constant VERSION = "1.2.0";

[x] Fixed

Low/Notes, No events for updateInflationPerSecond

updateInflationPerSecond()
no events for 
        // Update state variables
maxBond = uint96(curMaxBond);
effectiveBond = uint96(curEffectiveBond);
inflationPerSecond = uint96(curInflationPerSecond);

[x] Fixed

Update 12.03.25

The review has been performed based on the contract code in the following repository:
https://github.com/valory-xyz/autonolas-tokenomics
commit: 4ee649f9355eae5a42105dbc7ea066364db5ddf9 or tag: v1.3.2-pre-internal-audit

Storage and proxy

Using sol2uml tools: https://github.com/naddison36/sol2uml

sol2uml storage contracts/ -f png -c Tokenomics -o audits/internal6/
Generated png file audits/internal6/Tokenomics.png

From the point of view of auditing a proxy contract, only storage are important: Tokenomics.
Tokenomics-storage - 17 slots
Current contract storage Tokenomics-storage - 17 slots

md5sum Tokenomics-1.3.1.png Tokenomics-1.3.2.png 
dba13629f9483a95d8d537fddc38214c  Tokenomics-1.3.1.png
dba13629f9483a95d8d537fddc38214c  Tokenomics-1.3.2.png

OK.

Security issues.

No issue