-
Notifications
You must be signed in to change notification settings - Fork 86
Menu should not close when toggling a setting item #8827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The menu is closed by this logic which I think was originally introduced to handle cases where web-components/packages/menu-bar/src/vaadin-menu-bar-mixin.js Lines 419 to 422 in c67dec1
However, even with that logic removed, there would be still a problem caused to the fact that submenu overlay still has web-components/packages/overlay/src/vaadin-overlay-position-mixin.js Lines 234 to 237 in c67dec1
We could try to use Lit in |
Reopening since the PR will be reverted for now as the implementation breaks ITs in Flow counterpart. |
Created a PR with a new fix: #8871. Still need to figure out how to test the Flow component issue properly. |
Description
With a custom toggleable item in a menubar, the user should be able to toggle the item and the menu should be updated and also kept open. There does not seem to be a way to accomplish this at the moment.
Expected outcome
The user can open the menu, toggle a setting, the item text is updated and the user can toggle the next setting
Minimal reproducible example
Steps to reproduce
Use the code
Environment
Vaadin version(s): 24.7.0
OS: mac os
Browsers
No response
The text was updated successfully, but these errors were encountered: