Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade slash-commands support #6

Open
ghost opened this issue Mar 25, 2021 · 5 comments
Open

Upgrade slash-commands support #6

ghost opened this issue Mar 25, 2021 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 25, 2021

Currently, the tool checks for the whole comment body to match the command. It may be more convenient to check for the command to show up anywhere in the body of the comment.

@lazyparser
Copy link
Member

It may be a good idea to detect the first char of every line, leaving other slash strings untouched.

e.g.

/slash parse it
comment /do-not-parse

@ghost
Copy link
Author

ghost commented Mar 25, 2021

That's a good idea. Then we can just use the rest of that line for arguments to the command. So it could be:

/retest precheck
/retest all
/retest build run

@lazyparser
Copy link
Member

lazyparser commented Mar 25, 2021

Yes. That's exactly the way other slash commands utility/tools does.

After you pushed the initial codes, we can add more sub commands :)

@lazyparser
Copy link
Member

and the /retest should be the alias to /retest all :)

@lazyparser lazyparser self-assigned this Aug 21, 2021
@lazyparser
Copy link
Member

I've read the code. It's clean and clear :)
I'll continue to add new features if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant