From 8be75d398d4558bcbda94736f1619c5ec16b45f5 Mon Sep 17 00:00:00 2001 From: Gal Topper Date: Thu, 4 Jan 2024 20:12:02 +0800 Subject: [PATCH] Increase pyarrow version used in tests (#40) * Increase pyarrow version used in tests * Add fallback in makefile * Add fallback in makefile --- Makefile | 17 +++++++++++------ dev-requirements.txt | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 364c2ac..8034574 100644 --- a/Makefile +++ b/Makefile @@ -13,7 +13,12 @@ # limitations under the License. # We only want to format and lint checked in python files -CHECKED_IN_PYTHING_FILES := $(shell git ls-files | grep '\.py$$') +CHECKED_IN_PYTHON_FILES := $(shell git ls-files | grep '\.py$$') + +# Fallback +ifeq ($(CHECKED_IN_PYTHON_FILES),) +CHECKED_IN_PYTHON_FILES := . +endif FLAKE8_OPTIONS := --max-line-length 120 BLACK_OPTIONS := --line-length 120 @@ -26,8 +31,8 @@ all: .PHONY: fmt fmt: @echo "Running black fmt..." - python -m black $(BLACK_OPTIONS) $(CHECKED_IN_PYTHING_FILES) - python -m isort $(ISORT_OPTIONS) $(CHECKED_IN_PYTHING_FILES) + python -m black $(BLACK_OPTIONS) $(CHECKED_IN_PYTHON_FILES) + python -m isort $(ISORT_OPTIONS) $(CHECKED_IN_PYTHON_FILES) .PHONY: lint lint: flake8 fmt-check @@ -35,13 +40,13 @@ lint: flake8 fmt-check .PHONY: fmt-check fmt-check: @echo "Running black+isort fmt check..." - python -m black $(BLACK_OPTIONS) --check --diff $(CHECKED_IN_PYTHING_FILES) - python -m isort --check --diff $(ISORT_OPTIONS) $(CHECKED_IN_PYTHING_FILES) + python -m black $(BLACK_OPTIONS) --check --diff $(CHECKED_IN_PYTHON_FILES) + python -m isort --check --diff $(ISORT_OPTIONS) $(CHECKED_IN_PYTHON_FILES) .PHONY: flake8 flake8: @echo "Running flake8 lint..." - python -m flake8 $(FLAKE8_OPTIONS) $(CHECKED_IN_PYTHING_FILES) + python -m flake8 $(FLAKE8_OPTIONS) $(CHECKED_IN_PYTHON_FILES) .PHONY: test test: diff --git a/dev-requirements.txt b/dev-requirements.txt index c63538e..1481899 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -5,5 +5,5 @@ flake8~=5.0 flake8-bugbear~=22.9 isort~=5.7 pandas>=1.1 -pyarrow~=1.0 +pyarrow~=12.0 pytest>=6.0