Refactor Java code to comply with SonarCloud rule S1155

Replaced instances of collection.size() < 1 with collection.isEmpty(),
and collection.size() >= 1 with !collection.isEmpty().

Author: Rohit Singh Bhojak

java/code/src/com/redhat/rhn/frontend/action/configuration/sdc/FileListConfirmSubmitAction.java

@@ -102,7 +102,7 @@ public ActionForward importFile(ActionMapping mapping, ActionForm formIn,
         RhnSet set = RhnSetDecl.CONFIG_IMPORT_FILE_NAMES.get(user);
         Set cfnids = getCfnids(set);
         //if they don't have a set, don't do anything.
-        if (cfnids.size() < 1) {
+        if (cfnids.isEmpty()) {
             return createErrorMessage(request, mapping, formIn, server.getId(),
                     "sdcfilelist.jsp.noSelected");
         }
@@ -173,7 +173,7 @@ private ActionForward createRevisionAction(HttpServletRequest request, ActionFor
         RhnSet set = RhnSetDecl.CONFIG_FILE_NAMES.get(user);
         Set revisions = getCrids(set, sid);
         //if they don't have a set, don't do anything.
-        if (revisions.size() < 1) {
+        if (revisions.isEmpty()) {
             return createErrorMessage(request, mapping, form, sid,
                     "sdcfilelist.jsp.noSelected");
         }

java/code/src/com/redhat/rhn/frontend/action/configuration/sdc/FileListSubmitAction.java

@@ -93,7 +93,7 @@ public ActionForward goToConfirm(ActionMapping mapping,
                                      HttpServletRequest request,
                                      HttpServletResponse response) {
         //They didn't select anything. Tell them to select something.
-        if (updateSet(request).size() < 1) {
+        if (updateSet(request).isEmpty()) {
             ActionErrors errors = new ActionErrors();
             errors.add(ActionMessages.GLOBAL_MESSAGE,
                     new ActionMessage("sdcfilelist.jsp.noSelected"));

java/code/src/com/redhat/rhn/frontend/action/systems/SPMigrationAction.java

@@ -282,7 +282,7 @@ public ActionForward execute(ActionMapping actionMapping,
                 request.setAttribute(LATEST_SP, true);
                 return forward;
             }
-            else if (migrationTargets.size() >= 1) {
+            else if (!migrationTargets.isEmpty()) {
                 // At least one target available
                 logger.debug("Found at least one migration target");
                 request.setAttribute(TARGET_PRODUCTS, migrationTargets);

java/code/src/com/redhat/rhn/frontend/xmlrpc/user/UserHandler.java

@@ -996,7 +996,7 @@ public int addAssignedSystemGroups(User loggedInUser, String login, List<String>
         User targetUser = XmlRpcUserHelper.getInstance().lookupTargetUser(
                 loggedInUser, login);
 
-        if (sgNames == null || sgNames.size() < 1) {
+        if (sgNames == null || sgNames.isEmpty()) {
             throw new IllegalArgumentException("no servergroup names supplied");
         }
 

java/code/src/com/redhat/rhn/manager/action/ActionManager.java

@@ -233,7 +233,7 @@ public static Action lookupAction(User user, Long aid) {
         params.put("org_id", user.getOrg().getId());
         params.put("aid", aid);
         params.put("include_orphans", user.hasRole(RoleFactory.ORG_ADMIN) ? "Y" : "N");
-        if (m.execute(params).size() < 1) {
+        if (m.execute(params).isEmpty()) {
             returnedAction = null;
         }
 
@@ -577,7 +577,7 @@ public static Action createConfigUploadAction(User user, Set filenames, Server s
         }
 
         //if this is a pointless action, don't do it.
-        if (a.getConfigFileNameAssociations().size() < 1) {
+        if (a.getConfigFileNameAssociations().isEmpty()) {
             return null;
         }
 

java/code/src/com/redhat/rhn/manager/audit/CVEAuditManager.java

@@ -519,7 +519,7 @@ public static List<RankedChannel> addRelevantMigrationProductChannels(
 
                     // ...if it has a target with that base product...
                     List<SUSEProductDto> targets = findAllTargetProducts(suseProductID);
-                    if (log.isDebugEnabled() && targets.size() <= 0) {
+                    if (log.isDebugEnabled() && targets.isEmpty()) {
                         log.debug("No target products found for {}", suseProductID);
                     }
                     for (SUSEProductDto target : targets) {
@@ -552,7 +552,7 @@ public static List<RankedChannel> addRelevantMigrationProductChannels(
 
                     // ...if it has a source with that base product...
                     List<SUSEProductDto> sources = findAllSourceProducts(suseProductID);
-                    if (log.isDebugEnabled() && sources.size() <= 0) {
+                    if (log.isDebugEnabled() && sources.isEmpty()) {
                         log.debug("No source products found for {}", suseProductID);
                     }
                     for (SUSEProductDto source : sources) {

java/code/src/com/redhat/rhn/manager/system/SystemManager.java

@@ -2327,7 +2327,7 @@ public static boolean isAvailableToUser(User user, Long sid) {
         Map<String, Object> params = new HashMap<>();
         params.put("uid", user.getId());
         params.put("sid", sid);
-        return m.execute(params).size() >= 1;
+        return !m.execute(params).isEmpty();
     }
 
     /**

java/code/src/com/suse/manager/webui/controllers/SSOController.java

@@ -109,7 +109,7 @@ public static Object getACS(Request request, Response response) {
 
                     final Collection<String> keys = attributes.keySet();
 
-                    if (keys.contains((String) "uid") && attributes.get("uid").size() >= 1) {
+                    if (keys.contains((String) "uid") && !attributes.get("uid").isEmpty()) {
                         final Optional uidOpt = Optional.ofNullable(attributes.get("uid").get(0));
                         if (uidOpt.isPresent()) {
                             final User user = UserFactory.lookupByLogin(String.valueOf(uidOpt.get()));

java/code/src/com/suse/utils/Lists.java

@@ -50,7 +50,7 @@ private static <T> List<List<T>>  combinations(List<List<T>> acc, List<T> list)
      * @return cartesian product of the input
      */
     public static <T> List<List<T>>  combinations(List<List<T>> lists) {
-        if (lists.size() < 1) {
+        if (lists.isEmpty()) {
             return new ArrayList<>();
         }
         else {

java/spacewalk-java.changes

@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Tue Mar 18 16:01:30 UTC 2025 - Rohit Singh Bhojak <rohit@localhost>
+
+- Fixed SonarCloud Rule S1155 violations (gh#uyuni-project/uyuni#9947)
+
 -------------------------------------------------------------------
 Thu Mar 06 19:57:20 CET 2025 - [email protected]