From 7d9aa7ada51b690ac00715b074cf5a35639e48f2 Mon Sep 17 00:00:00 2001 From: Sorin Buliarca Date: Mon, 27 Jan 2025 14:13:01 +0200 Subject: [PATCH 1/2] Enable scaled jobs, as the CRDs are applied already sever side. --- kube-system/crds/kustomization.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/kube-system/crds/kustomization.yaml b/kube-system/crds/kustomization.yaml index 0829c73..2ed3b35 100644 --- a/kube-system/crds/kustomization.yaml +++ b/kube-system/crds/kustomization.yaml @@ -2,12 +2,3 @@ apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - crds.yaml - -patches: - # Due to https://github.com/kedacore/keda/issues/4740, removing, the scaledjobs.keda.sh CRD - - patch: |- - $patch: delete - apiVersion: apiextensions.k8s.io/v1 - kind: CustomResourceDefinition - metadata: - name: scaledjobs.keda.sh From a367ad2879c91e48c49d071985e40caafe3fbb3d Mon Sep 17 00:00:00 2001 From: Sorin Buliarca Date: Mon, 27 Jan 2025 14:13:29 +0200 Subject: [PATCH 2/2] Update README --- README.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/README.md b/README.md index d76ec42..32fe15e 100644 --- a/README.md +++ b/README.md @@ -31,13 +31,6 @@ Implementation details: Although the metrics API doesn't need all the permissions in these roles, we want to keep the manifests as close as possible to Keda upstream, to have a leaner upgrade experience. -### SclaledJobs limitation -Due to [this bug](https://github.com/kedacore/keda/issues/4740) we currently don't support [scaling jobs](https://keda.sh/docs/2.16/concepts/scaling-jobs/). - -We took the scaledjobs.keda.sh Custom Resource Definition out of the manifests. - -If you have a good use case for it please contact us. - ### Secrets access By default, Keda's RBAC configuration grants `cluster-wide access` to `secrets` for its components.