-
Notifications
You must be signed in to change notification settings - Fork 481
Implement getters akin to EVM opcodes #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Michael Müller <[email protected]>
|
One question related to #2597. Should |
|
@LucasGrasso As an FYI, I've changed the
to
So you no longer need someone to approve your runs. |
Excellent, That was a bugger. |
|
He @0xLucca would you be interested to rebase on master so that we can finish this PR? |
|
@cmichi can you help finishing this PR? |
davidsemakula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
See comment about BlockNumber type
davidsemakula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LucasGrasso
You just need to make rustfmt happy to make this ready to merge.
|
Ran rustfmt. Thanks @davidsemakula for the review! |
cmichi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Lucas!
|
All set, thanks to all for your help! |
Summary
Partially addresses #2653
cargo-contractorpallet-revive?Description
Implements the following host fns: