Skip to content

Caller is origin implementation #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 49 commits into from
Closed

Caller is origin implementation #1991

wants to merge 49 commits into from

Conversation

@ramirez7358
Copy link
Contributor

@ramirez7358 ramirez7358 commented Nov 14, 2023

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Description

Function

caller_is_origin()

Initial status

Not implemented in integration test

Issue documentation & test case

https://github.com/CoinFabrik/on-ink-integration-tests/tree/main/test-cases/caller-is-origin

Implementation note

We have added the depthfield to the ExecContext struct in order to be able to detect caller chages avery time calls are made between contracts.

Basically every time the callee changes in the instantiate_contract or invoke_contract function calls, one is aded to depth. And when the callee returns to the previous one, 1 is subtracted.

The caller_is_origin()function compares the value of depth to zero to check if the current contract caller is the origin of the entire call stack.

Testing guide

In the directory integration-tests/set_contract_storage of the target directory, we include in our pull request a test case showing that the observed implementation difference has been corrected. Note that this test is different from the original test case in our repository, which showed the difference.

In order to run the integration tests run:
cargo test

In order to run the e2e tests run:
cargo test -–features e2e-tests

These tests are run separately because we do not need to compare their results.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Helios-vmg and others added 30 commits October 27, 2023 17:43
@Helios-vmg
Implementing stuff needed for instantiate_contract().
e7f1b8f
@Helios-vmg
Implemented return_value() on integration tests.
506e95d 
# Conflicts:
#	crates/env/src/lib.rs
#	crates/env/src/reflect/event.rs
#	crates/ink/codegen/Cargo.toml
@Helios-vmg
A couple fixes for E2E environment.
bc8688b
@Helios-vmg
Forgot to delete some fluff.
6ccd54b
@Helios-vmg
Fixed dead code warnings.
34854c5
@Helios-vmg
Added tests.
c75ed7d
@Helios-vmg
Fixed-up tomls.
3ccb01f
@Helios-vmg
Updated stderr test files.
2d1950a
@Helios-vmg
Updated CHANGELOG.
2d13b21
@Helios-vmg
Passed through rustfmt.
817f3cc
@Helios-vmg
Passed through clippy.
6c4efc6
@Helios-vmg
Passed through rustfmt again.
25e1810
@Helios-vmg
Fixed failing contract builds.
3042f4d 
Moved reflection, contract, arithmetic, and miscellaneous types from ink_env
to ink_primitives.
@Helios-vmg
Revert "Updated stderr test files."
8f78fdd 
This reverts commit 2d1950a.
@Helios-vmg
Fixed format errors.
b350252
@Helios-vmg
Fixed failing test.
2dfb9ed
@Helios-vmg
Updated stderr test values.
a715026
@Helios-vmg
Fixed some dependencies for doc tests.
9c74b08
@Helios-vmg
Fixed rustfmt issues.
ea15b62
@Helios-vmg
Implemented code_hash() and set_code_hash().
4e8fdc9
@Helios-vmg
Minor behavior correction for instantiate_contract().
9981c7f
@Helios-vmg
Merge branch 'code_hash-implementation' into invoke_contract-implemen…
12297f8 
…tation
@Helios-vmg
Tentative invoke_contract() implementation.
b6478d9
@Helios-vmg
Added invoke_contract_delegate() skeleton.
4c04eba
@Helios-vmg
Obviated unsafe block.
7d4f265
@ramirez7358
own_code_hash implementation
94f3484
@ramirez7358
Add own-code-hash integration test
4de3aa0
@Helios-vmg
Remove unused use.
439e90c
@Helios-vmg
Merge branch 'code_hash-implementation' into invoke_contract-implemen…
1c33d83 
…tation

# Conflicts:
#	crates/engine/src/database.rs
@Helios-vmg
Added some missing semantics.
057e98c
@XianPaz XianPaz mentioned this pull request Nov 14, 2023
Open
@cmichi
Copy link
Collaborator

cmichi commented Nov 14, 2024

@ramirez7358 Sorry for pinging you only now about all those old PR's. Could you possibly merge master and resolve the conflicts here as well?

@cmichi
Copy link
Collaborator

cmichi commented Oct 14, 2025

Thanks for the work on this PR. It took a long while, but we now came to a decision that results in the closing of this PR. Some words on the reasoning and why it took so long:

The project moved out of Parity and with that came a period in which we didn't have funding and things were unclear. We resumed work a while ago to work on ink! v6; this is a migration away from WebAssembly and pallet-contracts to RISC-V and pallet-revive. We wrote down more context about this transition here.

While migrating to pallet-revive, we were uncertain how to handle the off-chain testing environment. We've now decided to remove it in favor of E2E tests against either a full node process or a sandboxed pallet-revive.

The reason for this decision is that the off-chain testing environment comes with a lot of maintenance costs and never fully reflected the on-chain behavior.

@cmichi cmichi closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@ascjones ascjones Awaiting requested review from ascjones

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramirez7358 @cmichi @Helios-vmg