Add hybrid search #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
reviewed
Dec 26, 2024
| @@ -89,3 +105,74 @@ export const awaitUntilIndexed = async (client: HttpClient | Index, timeoutMilli | |||
|
|
|||
| throw new Error(`Indexing is not completed in ${timeoutMillis} ms.`); | |||
| }; | |||
|
|
|||
| export const populateSparseIndex = async (index: Index, namespace: string) => { | |||
There was a problem hiding this comment.
Can we maybe parametrize this function with dimension count etc. and randomize the vectors? So that we can use it in multiple places
src/commands/client/types.ts
Outdated
| metadata?: TMetadata; | ||
| data?: string; | ||
| }; | ||
|
|
||
| export type NAMESPACE = string; | ||
|
|
||
| export type Dict = Record<string, unknown>; | ||
|
|
||
| export type SparseVector = [indices: number[], values: number[]]; |
There was a problem hiding this comment.
Can we add jsdocs for this type, so that people makes sense of its structure while coding
| @@ -1,11 +1,12 @@ | |||
| import type { NAMESPACE } from "@commands/client/types"; | |||
| import type { NAMESPACE, SparseVector } from "@commands/client/types"; | |||
| import { Command } from "@commands/command"; | |||
|
|
|||
| type NoInfer<T> = T extends infer U ? U : never; | |||
|
|
|||
| type VectorPayload<TMetadata> = { | |||
There was a problem hiding this comment.
This type allows both vector and sparseVector not be passed. At least one should be passed in type
src/commands/client/query/types.ts
Outdated
| fusionAlgorithm?: FusionAlgorithm; | ||
| queryMode?: QueryMode; | ||
| } & ( | ||
| | { vector?: number[]; sparseVector?: SparseVector; data?: never } |
There was a problem hiding this comment.
at least one of vector or sparseVector should be passed imo
CahidArda
force-pushed
the
DX-1497-hybrid-search
branch
from
10c907b to
880a25e
Compare
|
tests pass locally but fail on Github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI won't pass because we haven't created and added indexes which use sparse/hybrid index yet.
README will be updated once everything is finished.