fix: don't sleep after the last retry attempt (#52)

Author: CahidArda

src/http/index.test.ts

@@ -53,3 +53,32 @@ describe("Abort", () => {
     expect(bodyResponse.result).toEqual("Abort works!");
   });
 });
+
+describe.only("retry", () => {
+  test("should terminate after sleeping 5 times", async () => {
+    // init a cient which will always get errors
+    const client = newHttpClient(
+      {
+        retries: 5,
+        backoff: (retryCount) => Math.exp(retryCount) * 50,
+      },
+      {
+        url: "",
+        token: "non-existent",
+      }
+    );
+
+    // get should take 4.287 seconds and terminate before the timeout.
+    const throws = () =>
+      Promise.race([
+        client.request({
+          path: ["upsert"],
+          body: "wrong-body",
+        }),
+        new Promise((r) => setTimeout(r, 4500)),
+      ]);
+
+    // if the Promise.race doesn't throw, that means the retries took longer than 4.5s
+    expect(throws).toThrow("fetch() URL is invalid");
+  });
+});

src/http/index.ts

@@ -132,7 +132,9 @@ export class HttpClient implements Requester {
           break;
         }
         error = error_ as Error;
-        await new Promise((r) => setTimeout(r, this.retry.backoff(i)));
+        if (i < this.retry.attempts) {
+          await new Promise((r) => setTimeout(r, this.retry.backoff(i)));
+        }
       }
     }
     if (!res) {