Update AKS version field to current supported versions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples |
|
@djeremiah can you please update the manifests in examples folder ? i wonder if we really want to with latest version as default |
|
It's a fair question. configuration-gcp-gke uses "latest". configuration-aws-eks uses "1.27", but those clusters immediately get flagged as needing upgrades. Based on the current info in https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#kubernetes-versions, 1.28 seems like a good compromise for this moment in time. |
|
/test-examples |
1 similar comment
|
/test-examples |
This was referenced Feb 27, 2024
…tly available versions Signed-off-by: Murph <[email protected]>
Signed-off-by: Murph <[email protected]>
djeremiah
force-pushed
the
update-k8s-versions
branch
from
eb7b6ec to
a1401e9
Compare
|
/test-examples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move to minor version names instead of patch version names.
Description of your changes
The api definition had an enum with a limited set of patch-level versions for AKS. These are no longer supported versions in all regions. This PR moves the list to only specify the minor version, and updates the list to match the current set of available k8s versions.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Deployed the configuration into an Upbound control plane and provisioned an AKS cluster