Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow null for Select, Combobox, ToggleGroup, etc. #1512

Open
1 of 2 tasks
kilobyte2007 opened this issue Dec 19, 2024 · 2 comments
Open
1 of 2 tasks

[Feature]: Allow null for Select, Combobox, ToggleGroup, etc. #1512

kilobyte2007 opened this issue Dec 19, 2024 · 2 comments
Labels

Comments

@kilobyte2007
Copy link
Contributor

Describe the feature

Hi, I have already raised this in #880 but I see it's closed as fixed, but it was only fixed inside the nullish check and the type was not adjusted accordingly.

In v2 (1 alpha) I see that AcceptableValue is used everywhere alongside | undefined for modelValue, but in a lot of cases allowing a null alongside undefined makes sense as we often can have a null value come from a database and or an endpoint.

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@zernonia zernonia added the v2 label Dec 21, 2024
@zernonia
Copy link
Member

Thanks for bringing this up again @kilobyte2007 ! The previous fix was to accept null for rendering the placeholder. We will handle this change in v2 as we want to make it consistent with other form components 😁

@zernonia zernonia added this to v2 Dec 21, 2024
@zernonia zernonia moved this to Backlog in v2 Dec 21, 2024
@DamianGlowala
Copy link
Contributor

@zernonia adding my comment which might be relevant to the scope of this issue #1485 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

3 participants