Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable x86 for Android and x86_64 for iOS #22

Open
Johennes opened this issue Jan 29, 2025 · 2 comments · May be fixed by #24
Open

Re-enable x86 for Android and x86_64 for iOS #22

Johennes opened this issue Jan 29, 2025 · 2 comments · May be fixed by #24

Comments

@Johennes
Copy link
Collaborator

Due to size limits on npmjs.com, we had to disable some x86 for Android and x86_64 for iOS with 54ca156 and 58b948f. Ideally we'd be able to distribute the binaries for these platforms as well.

I couldn't find it documented but the size limit might be around 200mb packed. Without these architectures, the package is around 175mb.

Possible solutions I've thought of so far:

  1. Don't include any binaries at all and let consumers build them on their own
  2. Host the binaries somewhere else and download them with a package.json script on install

CC @olliiiver since you've contributed some fixes for the x86 builds in the past and might possibly be relying on them.

@olliiiver
Copy link
Contributor

Hi @Johennes.

Thanks for providing an update to the library.

I think removing x86 for Android is fine since most people are on x86_64 nowadays. I'm not entirely sure about Intel Macs after removing x86_64 for iOS, but looks like the Github workflows are still running.

We could think about having the prebuilds downloaded like node-canvas is doing it:

https://github.com/Automattic/node-canvas

They use prebuild-install to download binaries from Github:

https://www.npmjs.com/package/prebuild-install

@Johennes
Copy link
Collaborator Author

Oh, interesting. So we could attach the binaries to a GitHub release and then fetch them from there, e.g. with a postinstall step. That sounds feasible.

@Johennes Johennes linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants