- closeAccountRequest changed from class to interface (#268)

- added create close account request helper function
- added a test for close account

Author: axshani

helpers.ts

@@ -1,4 +1,4 @@
-import { AddAuthorizedUsersRequest, MobileWalletPayloadRequest, RemoveAuthorizedUsersRequest } from "./types"
+import { AddAuthorizedUsersRequest, CloseAccountRequest, CloseReason, MobileWalletPayloadRequest, RemoveAuthorizedUsersRequest } from "./types"
 import { State, Address, FullName, Phone, Status, Title, Officer, BeneficialOwner, BusinessContact, AuthorizedUser, Counterparty, Coordinates, UsAddress, InternationalAddress, Relationship, RelationshipsArrayData } from "./types/common"
 export function createUsAddress(street: string, street2: string | null, city: string, state: State | null, postalCode: string, country: "US"): UsAddress {
     return {
@@ -157,3 +157,15 @@ export function createMobileWalletRequest(cardId: string, signedNonce: string):
     }
 }
 
+export function createCloseAccountRequest(accountId: string, closeReason: CloseReason = "ByCustomer" ): CloseAccountRequest {
+    return {
+        accountId: accountId,
+        data: {
+            type: "accountClose",
+            attributes: {
+                reason: closeReason
+            }
+        }
+    }
+}
+

resources/account.ts

@@ -23,7 +23,7 @@ export class Accounts extends BaseResource {
     }
 
     public async closeAccount(request: CloseAccountRequest): Promise<UnitResponse<Account>> {
-        return this.httpPost<UnitResponse<Account>>(`/${request.accountId}/close`, request.to_json())
+        return this.httpPost<UnitResponse<Account>>(`/${request.accountId}/close`, {data: request.data})
     }
 
     public async reopenAccount(accountId: string): Promise<UnitResponse<Account>> {

tests/accounts.spec.ts

@@ -2,7 +2,7 @@ import { Unit } from "../unit"
 import { AccountOwnersRequest, DepositAccount } from "../types/account"
 
 import dotenv from "dotenv"
-import { createRelationshipArray } from "../helpers"
+import { createCloseAccountRequest, createRelationshipArray } from "../helpers"
 import { createIndividualAccount, createIndividualCustomer } from "./testHelpers"
 dotenv.config()
 const unit = new Unit(process.env.UNIT_TOKEN || "test", process.env.UNIT_API_URL || "test")
@@ -40,7 +40,7 @@ describe("Create Account", () => {
 })
 
 describe("Add Account Owners", () => {
-    test("add account owners", async () => {
+    test("Add and remove owners", async () => {
         const new_account = (await createIndividualAccount(unit)).data as DepositAccount
         const originated_customer_id = new_account.relationships.customer?.data.id
         const customer_id1 = await createIndividualCustomer(unit)
@@ -71,3 +71,15 @@ describe("Add Account Owners", () => {
     })
 })
 
+describe("Close Account", () => {
+    test("Close Deposit Account", async () => {
+        const res = await createIndividualAccount(unit)
+        const account = (await unit.accounts.get(res.data.id)).data
+        expect(account.type).toBe("depositAccount")
+
+        const closedAccount = (await unit.accounts.closeAccount(createCloseAccountRequest(account.id))).data as DepositAccount
+        expect(account.type).toBe("depositAccount")
+        expect(closedAccount.attributes.status).toBe("Closed")
+    })
+})
+

types/account.ts

@@ -292,28 +292,16 @@ export interface AccountDepositProduct {
     }
 }
 
-type CloseReason = "ByCustomer" | "Fraud"
+export type CloseReason = "ByCustomer" | "Fraud"
 
-export class CloseAccountRequest {
-    public accountId: string
-    public reason: CloseReason
-
-    constructor(accountId: string, reason: CloseReason = "ByCustomer") {
-        this.accountId = accountId
-        this.reason = reason
-    }
+export interface CloseAccountRequest {
+    accountId: string
 
-    public to_json(): any {
-        const data: any = {
-            "data": {
-                "type": "accountClose",
-                "attributes": {
-                    "reason": this.reason
-                }
-            }
+    data: {
+        type: "accountClose"
+        attributes: {
+            reason: CloseReason
         }
-
-        return data
     }
 }