Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UI options don't work? #39

Closed
nedkamburov opened this issue Sep 13, 2023 · 4 comments
Closed

Some UI options don't work? #39

nedkamburov opened this issue Sep 13, 2023 · 4 comments
Labels
documentation help wanted Extra attention is needed

Comments

@nedkamburov
Copy link

nedkamburov commented Sep 13, 2023

Hello there, I have been implementing this library with relative ease and joy but I have hit a roadblock.

This is my options config for the fontsampler:

{
      order: [["fontfamily", "language", "fontsize", "alignment", "opentype"], "tester"],
      ui: {
        tester: {
          editable: false,
          label: false,
        },

        language: {
          choices: ["enGB|English", "deDe|Deutsch", "nlNL|Dutch"],
          init: "enGb",
          label: false,
        },

        opentype: {
          choices: ["liga|Ligatures", "frac|Fractions"],
          init: ["liga"],
          label: "Opentype features",
        },
      },
      lazyload: true,
    }

The order, language ui choices and lazyload work however any options for the tester or the label field on any feature doesn't do anything...

@kontur Am I using the wrong data structure or I am missing something? Thanks a lot!

@nedkamburov
Copy link
Author

I think I found the culprit, the field should be called config, not ui... There definitely should be an update of the docs.

config: {
        tester: {
          editable: false,
          label: false,
        }
}

@kontur
Copy link
Collaborator

kontur commented Sep 26, 2023

There definitely should be an update of the docs.

Oh yes, I must have missed that rename in the docs, my bad! Feel free to send a PR with the text corrected in the docs.

@kontur kontur added help wanted Extra attention is needed documentation labels Sep 26, 2023
@nedkamburov
Copy link
Author

nedkamburov commented Sep 27, 2023

I forked the project to take a look and it seems like the online version is a little different.

I cannot seem to find the source anywhere in the codebase. Is it possible that the static version is using an old version of index.html? @kontur

@kontur
Copy link
Collaborator

kontur commented Sep 17, 2024

Finally had a look at these and fixed some things that were off with the documentation 👍

@kontur kontur closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants