Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for S3 media file storage #28

Open
amit-ch opened this issue Jan 7, 2022 · 5 comments
Open

Support for S3 media file storage #28

amit-ch opened this issue Jan 7, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@amit-ch
Copy link

amit-ch commented Jan 7, 2022

Earlier in v8, we used https://github.com/DannerrQ/Umbraco-S3-Provider for storing/retrieving media files from S3. Good to see support for Azure blob storage now but we would like to continue using S3 for media files.

Is there any plan to provide support for S3 storage provider

@benmccallum
Copy link

benmccallum commented Jan 14, 2022

+1 , it seems @ronaldbarendse has a couple of PRs that might make this easier, so I'm hesitant to go ahead and copy-paste-adjust the Azure one if it's going to be a one-file-and-done for S3 after those PRs.

FYI, S3's client sdk (since v3.5) is async-only, so they're gonna need to be forced sync, but until the interface uses async methods there's not a lot that can be done there. Was previously discussed here.

@snovak7
Copy link

snovak7 commented Feb 12, 2022

I don't see problem with async on sync, Azure methods probably use the same pattern internally... Also, S3 doesn't have Image mechanism, which was tightly coupled to Azure.

Another thing is that "current" Azure Storage Providers could be dissected further since, CDN Media Url Provider could be re-used in S3.

I'm trying to do an integration with current limitations, will see how it works out.

@snovak7
Copy link

snovak7 commented Mar 3, 2022

I have this working, with limitations as described in previous comment.

Next step would be to add a "pre-processor" for media, to let's say strip metadata from the images, and maybe optimize images for upload to Storage Provider.

@DennisGlindhart
Copy link

I've made a S3-fork available here - https://github.com/DennisGlindhart/Umbraco.StorageProviders.S3
Early state, but basics seems to work.

@ronaldbarendse ronaldbarendse added enhancement New feature or request help wanted Extra attention is needed labels May 11, 2022
@ronaldbarendse
Copy link
Contributor

I don't expect Umbraco will be adding official S3 support anytime soon, so this will currently need to rely on community efforts.

Besides the fork @DennisGlindhart mentioned above, I'm also aware of https://github.com/adam-werner/Our.Umbraco.StorageProviders.AWSS3 (which is currently also the only one listed on the Marketplace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants