Add more tests

Author: rasmusjp

src/Our.Umbraco.GraphQL/Adapters/GraphTypeAdapter.cs

@@ -214,7 +214,8 @@ private QueryArgument CreateArgument(ParameterInfo parameterInfo)
             IGraphType inputType;
             if (unwrappedType == typeof(OrderBy))
             {
-                var returnType = parameterInfo.Member.GetReturnType();
+                var returnType = parameterInfo.Member.GetReturnType().Unwrap();
+
                 if (returnType.IsGenericType && returnType.GetGenericTypeDefinition() == typeof(Connection<>))
                     returnType = returnType.GenericTypeArguments[0].GetTypeInfo();
 
@@ -225,6 +226,7 @@ private QueryArgument CreateArgument(ParameterInfo parameterInfo)
                     : Activator.CreateInstance(foundType);
 
                 inputType = new OrderByGraphType((IComplexGraphType) graphType);
+                _visitor.Visit((EnumerationGraphType) inputType);
 
                 if (parameterType.IsGenericType && parameterType.GetGenericTypeDefinition() == typeof(IEnumerable<>))
                 {

src/Our.Umbraco.GraphQL/Adapters/PublishedContent/Types/ContentVariationGraphType.cs

@@ -12,6 +12,7 @@ public class ContentVariationGraphType : EnumerationGraphType<ContentVariation>
         public ContentVariationGraphType()
         {
             Name = TypeName;
+            Description = "Indicates how values can vary.";
         }
     }
 }

src/Our.Umbraco.GraphQL/Adapters/PublishedContent/Types/PublishedItemTypeGraphType.cs

@@ -12,6 +12,7 @@ public class PublishedItemTypeGraphType : EnumerationGraphType<PublishedItemType
         public PublishedItemTypeGraphType()
         {
             Name = TypeName;
+            Description = "The type of published element.";
         }
     }
 }

src/Our.Umbraco.GraphQL/Adapters/PublishedContent/Types/UrlModeGraphType.cs

@@ -12,6 +12,7 @@ public class UrlModeGraphType : EnumerationGraphType<UrlMode>
         public UrlModeGraphType()
         {
             Name = TypeName;
+            Description = "Specifies the type of urls that the url provider should produce, Auto is the default.";
         }
     }
 }

src/Our.Umbraco.GraphQL/Adapters/PublishedContent/Visitors/PublishedContentVisitor.cs

@@ -105,7 +105,7 @@ public override void Visit(ISchema schema)
             }
         }
 
-        private void CreateContentField<T>(ObjectGraphType<T> query, IComplexGraphType graphType,
+        private void CreateContentField<T>(ComplexGraphType<T> query, IComplexGraphType graphType,
             IPublishedContentType publishedContentType,
             Func<IPublishedContentCache, string, IEnumerable<IPublishedContent>> fetch)
         {
@@ -114,15 +114,18 @@ private void CreateContentField<T>(ObjectGraphType<T> query, IComplexGraphType g
                 .Bidirectional()
                 .Resolve(ctx =>
                 {
-                    var items = fetch(_publishedSnapshotAccessor.PublishedSnapshot.Content, ctx.GetArgument<string>("culture")).ToList();
+                    var items = fetch(_publishedSnapshotAccessor.PublishedSnapshot.Content,
+                        ctx.GetArgument<string>("culture")).ToList();
 
                     return items.OrderBy(ctx.GetArgument<IEnumerable<OrderBy>>("orderBy"))
-                    .ToConnection(x => x.Key, ctx.First, ctx.After, ctx.Last, ctx.Before, items.Count);
+                        .ToConnection(x => x.Key, ctx.First, ctx.After, ctx.Last, ctx.Before, items.Count);
                 });
 
             var connectionField = query.GetField(publishedContentType.Alias);
             connectionField.ResolvedType = new ConnectionGraphType(graphType);
-            connectionField.Arguments.Add(new QueryArgument(new ListGraphType(new NonNullGraphType(new OrderByGraphType(graphType)))) { Name = "orderBy" });
+            connectionField.Arguments.Add(
+                new QueryArgument(new ListGraphType(new NonNullGraphType(new OrderByGraphType(graphType))))
+                    {Name = "orderBy"});
         }
     }
 }

src/Our.Umbraco.GraphQL/Adapters/Types/IdGraphType.cs

@@ -10,6 +10,7 @@ public override object ParseValue(object value)
             var parsed = base.ParseValue(value);
             return parsed == null ? (Id?)null : new Id(parsed.ToString());
         }
+
         public override object ParseLiteral(IValue value)
         {
             var parsed = base.ParseLiteral(value);

src/Our.Umbraco.GraphQL/Adapters/Types/UdiGraphType.cs

@@ -8,7 +8,7 @@ public class UdiGraphType : ScalarGraphType
     {
         public UdiGraphType()
         {
-            Name = "Udi";
+            Name = "UDI";
             Description = "Represents an entity identifier.";
         }
 

src/Our.Umbraco.GraphQL/Compose/GraphQLComposer.cs

@@ -12,6 +12,7 @@
 using Newtonsoft.Json;
 using Our.Umbraco.GraphQL.Adapters.PublishedContent.Visitors;
 using GraphQL.DataLoader;
+using Our.Umbraco.GraphQL.FieldMiddleware;
 using Our.Umbraco.GraphQL.Middleware;
 
 namespace Our.Umbraco.GraphQL.Compose

src/Our.Umbraco.GraphQL/Middleware/EnsureHttpContextFieldMiddleware.cs renamed to src/Our.Umbraco.GraphQL/FieldMiddleware/EnsureHttpContextFieldMiddleware.cs

@@ -2,9 +2,10 @@
 using System.Web;
 using GraphQL.Instrumentation;
 using GraphQL.Types;
+using Our.Umbraco.GraphQL.Middleware;
 using Umbraco.Web;
 
-namespace Our.Umbraco.GraphQL.Middleware
+namespace Our.Umbraco.GraphQL.FieldMiddleware
 {
     internal class EnsureHttpContextFieldMiddleware : IFieldMiddleware
     {